From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Cc: Sughosh Ganu <sughosh.ganu@arm.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package
Date: Wed, 21 Nov 2018 23:17:36 +0100 [thread overview]
Message-ID: <CAKv+Gu-1eaAbeO-bsxu-9Tr9uR7nYNEfGgpX10hNeUsL=g6w7g@mail.gmail.com> (raw)
In-Reply-To: <CAJuA9aj7rG_GA7=zqR2bEE53QYpoOm=6ZDv=wZuUbGC9Omcf3A@mail.gmail.com>
On Wed, 21 Nov 2018 at 17:01, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> Hi Ard, Leif,
>
> On Mon, Nov 19, 2018 at 10:39 AM Sughosh Ganu <sughosh.ganu@arm.com> wrote:
> >
> > hi Ard,
> >
> > On Thu Oct 25, 2018 at 01:02:33PM +0530, Sughosh Ganu wrote:
> > > The following patch series adds support for Management Mode related
> > > changes for aarch64 based platforms.
> > >
> > > Changes since v2:
> > > Based on review comments from Ard, moved the memory attribute updation
> > > changes out of DebugPeCoffExtraActionLib into an extra action library
> > > added in StandaloneMM package. The patch for setting the memory
> > > attributes, now under StandaloneMmPkg directory, will be submitted
> > > separately from this series.
> >
> > Can you please review the V3 of this series. Based on your review
> > comments, i have moved the memory attribute updation into an extra
> > action lib added under StandaloneMmPkg. Can you please check if these
> > updated patches for ArmPkg[1] and the one under StandaloneMmPkg[2] are
> > fine.
> >
> > I had put you and Leif on Cc while sending out the patches, but i
> > think that the mailserver deleted those, which is why you may have
> > missed the patches.
> >
> > -sughosh
> >
> > [1] - https://lists.01.org/pipermail/edk2-devel/2018-October/031377.html
> > [2] - https://lists.01.org/pipermail/edk2-devel/2018-October/031384.html
> >
> > >
> > >
> > > Achin Gupta (5):
> > > ArmPkg: Add PCDs needed for MM communication driver.
> > > ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
> > > ArmPkg/Include: Add MM interface SVC return codes.
> > > ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> > > ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
> > >
> > > Sughosh Ganu (1):
> > > ArmPkg/Include: Fix the SPM version SVC ID
> > >
> > > ArmPkg/ArmPkg.dec | 3 +
> > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 56 +++
> > > ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} | 23 +-
> > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 28 ++
> > > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 +-
> > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 395 ++++++++++++++++++++
> > > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c | 204 ++++++++++
> > > 7 files changed, 704 insertions(+), 14 deletions(-)
> > > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> > > copy ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} (51%)
> > > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
> > > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
> > > create mode 100644 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c
>
> Any feedback on this patch series. This series is important in getting
> the MM Standalone mode feature supported for Arm platforms. There are
> patches being worked on to enable secure variable access feature for
> Arm platforms and it depends on this series. So if there any comments
> on these patches, please let us know.
>
I will look into these patches before the end of the week.
prev parent reply other threads:[~2018-11-21 22:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 7:32 [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package Sughosh Ganu
2018-10-25 7:32 ` [PATCH v3 1/6] ArmPkg: Add PCDs needed for MM communication driver Sughosh Ganu
2018-10-25 7:32 ` [PATCH v3 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver Sughosh Ganu
2018-11-23 18:20 ` Ard Biesheuvel
2018-10-25 7:32 ` [PATCH v3 3/6] ArmPkg/Include: Fix the SPM version SVC ID Sughosh Ganu
2018-10-25 7:32 ` [PATCH v3 4/6] ArmPkg/Include: Add MM interface SVC return codes Sughosh Ganu
2018-10-25 7:32 ` [PATCH v3 5/6] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0 Sughosh Ganu
2018-10-25 7:32 ` [PATCH v3 6/6] ArmPkg/ArmMmuLib: Add MMU library inf file " Sughosh Ganu
2018-11-23 18:28 ` Ard Biesheuvel
2018-11-25 5:58 ` Sughosh Ganu
2018-11-19 4:48 ` [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package Sughosh Ganu
2018-11-19 5:00 ` Sughosh Ganu
2018-11-21 16:01 ` Thomas Abraham
2018-11-21 22:17 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-1eaAbeO-bsxu-9Tr9uR7nYNEfGgpX10hNeUsL=g6w7g@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox