From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A38E52118C51C for ; Wed, 21 Nov 2018 14:17:48 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id x19so11308024itl.1 for ; Wed, 21 Nov 2018 14:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fpckr7tK7O+LE86fXUth34I8OeHGeY3R7PKF5GvV5Mc=; b=V+xBQ//DA3bx8cMr4hnsWQgCoMrB82xqN+FCZA2bsMxs3ZmhyO/lXnhN2zZc5US2eW kRfcrK/d4lGC8ipNVL5jW/7NGL+heQtdSokjsQRrsgydv7T83xPtrMg0MUMuMatic2lL ihxfCmPXRVMc64WRWYdCG0u4dXlVXQ0Wc1uug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fpckr7tK7O+LE86fXUth34I8OeHGeY3R7PKF5GvV5Mc=; b=jNlKSw226LFJacabGpkk1MEpey2ezylIy3kS0C2dg6XqzVPkFknWNFWQjeyrgGmqsp 0btz25v2mi84MbhAzLxqQq3s5OPkhCpd++twFtr7vLcBNfNtHTvT0mLvTvX0rIq2MAks 9EmhNRdm9WRIKn+ljiBqcbv13XnHMlkp8MCYYoitCjoOd/sq4X6WK3E2SZFnSlq1F0Dd vkDcRiLr+txxwpv3E9dv1QdHOe6VEH9vjvO6SDMpDEPNYu5D3hewb3rdoT/h3L4oPVDx L3M5jtzBiVJDTNDJsiF0GbNAP7Rt4hC5C8fGaJeUSkuTvwsVU9cDOyBLSupE6T0PzBAl 1ZTA== X-Gm-Message-State: AGRZ1gI+b1/+J7VU6Xb+3c+BrDYX8Iq0mL5p+bWxig0SIBgScFq/iHJ5 oxBgQS0NWxaIxJ3tbUfe/laNW2VzwILiDLIYFk7pQNJEv9U= X-Google-Smtp-Source: AFSGD/UoNkPblFTFEul/mgIBIQW76/kANmK0fEevvpUHgz3vY8n+8UNATydAJS3xhwhrUk1MateP4mYqIQGCrtR4mDI= X-Received: by 2002:a24:710:: with SMTP id f16mr6720211itf.121.1542838667907; Wed, 21 Nov 2018 14:17:47 -0800 (PST) MIME-Version: 1.0 References: <1540452759-4875-1-git-send-email-sughosh.ganu@arm.com> <20181119050045.GA4937@arm.com> In-Reply-To: From: Ard Biesheuvel Date: Wed, 21 Nov 2018 23:17:36 +0100 Message-ID: To: Thomas Panakamattam Abraham Cc: Sughosh Ganu , Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 22:17:48 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 21 Nov 2018 at 17:01, Thomas Abraham wrote: > > Hi Ard, Leif, > > On Mon, Nov 19, 2018 at 10:39 AM Sughosh Ganu wrote: > > > > hi Ard, > > > > On Thu Oct 25, 2018 at 01:02:33PM +0530, Sughosh Ganu wrote: > > > The following patch series adds support for Management Mode related > > > changes for aarch64 based platforms. > > > > > > Changes since v2: > > > Based on review comments from Ard, moved the memory attribute updation > > > changes out of DebugPeCoffExtraActionLib into an extra action library > > > added in StandaloneMM package. The patch for setting the memory > > > attributes, now under StandaloneMmPkg directory, will be submitted > > > separately from this series. > > > > Can you please review the V3 of this series. Based on your review > > comments, i have moved the memory attribute updation into an extra > > action lib added under StandaloneMmPkg. Can you please check if these > > updated patches for ArmPkg[1] and the one under StandaloneMmPkg[2] are > > fine. > > > > I had put you and Leif on Cc while sending out the patches, but i > > think that the mailserver deleted those, which is why you may have > > missed the patches. > > > > -sughosh > > > > [1] - https://lists.01.org/pipermail/edk2-devel/2018-October/031377.html > > [2] - https://lists.01.org/pipermail/edk2-devel/2018-October/031384.html > > > > > > > > > > > Achin Gupta (5): > > > ArmPkg: Add PCDs needed for MM communication driver. > > > ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. > > > ArmPkg/Include: Add MM interface SVC return codes. > > > ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. > > > ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. > > > > > > Sughosh Ganu (1): > > > ArmPkg/Include: Fix the SPM version SVC ID > > > > > > ArmPkg/ArmPkg.dec | 3 + > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 56 +++ > > > ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} | 23 +- > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 28 ++ > > > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 +- > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 395 ++++++++++++++++++++ > > > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c | 204 ++++++++++ > > > 7 files changed, 704 insertions(+), 14 deletions(-) > > > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > copy ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} (51%) > > > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h > > > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > create mode 100644 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c > > Any feedback on this patch series. This series is important in getting > the MM Standalone mode feature supported for Arm platforms. There are > patches being worked on to enable secure variable access feature for > Arm platforms and it depends on this series. So if there any comments > on these patches, please let us know. > I will look into these patches before the end of the week.