Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in
> > > the code in patch #2 to expose a SSDT with a device node describing
> > > OP-TEE when booting in ACPI mode and OP-TEE is present.
> >
> > If we need any more SSDTs for this platform in future, I'll probably
> > start grumbling about refactoring away the per-table global variables,
> > but I guess it would be a bit overkill at this point...
> >
>
> Yeah, the thought crossed my mind as well, but let's defer that to the
> next time.
>
> > For the series:
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >
>

Actually, I need to apply this on top

--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
@@ -282,13 +282,16 @@ InstallAcpiTables (
     return;
   }

+  if (mEmmcSsdtSize > 0) {
     Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize,
                           &TableKey);
     if (EFI_ERROR (Status)) {
       DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n",
         __FUNCTION__, Status));
     }
+  }

+  if (mTos0SsdtSize > 0) {
     Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize,
                           &TableKey);
     if (EFI_ERROR (Status)) {
@@ -296,6 +299,7 @@ InstallAcpiTables (
         __FUNCTION__, Status));
     }
   }
+}

 EFI_STATUS
 EFIAPI

or we will call InstallAcpiTable() with a zero size if we're only
installing one of the tables.