From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by mx.groups.io with SMTP id smtpd.web09.1854.1575280734428960669
 for <devel@edk2.groups.io>;
 Mon, 02 Dec 2019 01:58:54 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=vdYZy/mC;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f66.google.com with SMTP id u8so6894198wmu.0
        for <devel@edk2.groups.io>; Mon, 02 Dec 2019 01:58:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=9sByZzlmJ/tgaikTaqz3Ysjls7NZxBYoPbSbT3j+kvQ=;
        b=vdYZy/mCU8k4pTbrShmQ6QADWmYBlVmkdn6oWPWrgt2rz+DDjUWYb1HZ8/Pu3NkTSg
         +ksTEBynzg62aw1Xe9MVhTc3DYhUIadyi6+ThYWswhiO1UF9aTvJ8DPHXUBzCpXSi7sf
         y6plxzfVf2XjoiXezoiVIi4QICywjXwFrFv2KO5L/nzT8uTSJulT+/Pvq0QVaNglJJcx
         crwyvEOjg22oWTvp6yTOtHcRbHcrHdeMAFqnjufZ0SJEMIX/QnQ1f/h3YlnuUD3OVXil
         XAV8kl4ymU48lCytDI7vOyCjHPUFWuvWWAcyarvjn2J1UpZszOp6Y2EQOIGIwiMsOU8H
         W9+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=9sByZzlmJ/tgaikTaqz3Ysjls7NZxBYoPbSbT3j+kvQ=;
        b=tW4XrvytdCrqu45Pxq9LrUv2YjfziidfhJDRt4EspwXLqBhsLbAVMzghj6zZcUffbO
         RvmsPAnbPIjpgkwGC4fnsVWQMQW7DnUSHJc4zAps97xiK9Jk+tVwmqNYu7FeundJXr+p
         tw7Eh67tAYPs9kxARJQjQx0J9MFnTl/O7oLvxzBHoX7MQd/0CBo6WQdBcpUEF+2fbiz2
         N/Pb6mAkQWiGvU9bcJiujqv+YCqC9/rPX0EBgrZatJejXoPwOCe53aS//M8tVFCZ6J0U
         t+Mbb6R/OFF4P6DSHO/NfyuWT1cAjCl66XQIwKzw9tz4+ciGq9FAhyY4omYJJMlj+xua
         IpEQ==
X-Gm-Message-State: APjAAAWYGJWnU46SFF/1iuk2LZlaZA8a4hZ135/35Db9V7FoClbans4I
	5XR4ENh6SaIqHh8Lmg1c4cp7rBcnEy0wjyqykcxUCQ==
X-Google-Smtp-Source: APXvYqx4a/BNKNbHAh/3zzsQXmxkdcWyPG/EtzggNh6cCSMex3kMdEn0D3i5tq2alyw3q+Bz9Bmci/z/sxjKJbfu+Q0=
X-Received: by 2002:a1c:4c10:: with SMTP id z16mr25783421wmf.136.1575280732858;
 Mon, 02 Dec 2019 01:58:52 -0800 (PST)
MIME-Version: 1.0
References: <20191129104716.819-1-ard.biesheuvel@linaro.org>
 <20191129112926.GA7359@bivouac.eciton.net> <CAKv+Gu-YcSQ0erMu51AH-G1PWO6aEk4C_0nJM43NmV408PzVTA@mail.gmail.com>
In-Reply-To: <CAKv+Gu-YcSQ0erMu51AH-G1PWO6aEk4C_0nJM43NmV408PzVTA@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 2 Dec 2019 10:58:45 +0100
Message-ID: <CAKv+Gu-2AE1hqegkt0d1unKQYFoSa+odFy0DtXftaa56Yxr+5Q@mail.gmail.com>
Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in
> > > the code in patch #2 to expose a SSDT with a device node describing
> > > OP-TEE when booting in ACPI mode and OP-TEE is present.
> >
> > If we need any more SSDTs for this platform in future, I'll probably
> > start grumbling about refactoring away the per-table global variables,
> > but I guess it would be a bit overkill at this point...
> >
>
> Yeah, the thought crossed my mind as well, but let's defer that to the
> next time.
>
> > For the series:
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >
>

Actually, I need to apply this on top

--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
@@ -282,13 +282,16 @@ InstallAcpiTables (
     return;
   }

+  if (mEmmcSsdtSize > 0) {
     Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize,
                           &TableKey);
     if (EFI_ERROR (Status)) {
       DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n",
         __FUNCTION__, Status));
     }
+  }

+  if (mTos0SsdtSize > 0) {
     Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize,
                           &TableKey);
     if (EFI_ERROR (Status)) {
@@ -296,6 +299,7 @@ InstallAcpiTables (
         __FUNCTION__, Status));
     }
   }
+}

 EFI_STATUS
 EFIAPI

or we will call InstallAcpiTable() with a zero size if we're only
installing one of the tables.