From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=Fywowxeu;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Tue, 17 Sep 2019 01:24:12 -0700
Received: by mail-wm1-f66.google.com with SMTP id g207so2163952wmg.5
        for <devel@edk2.groups.io>; Tue, 17 Sep 2019 01:24:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=lRdDK7qYLK/zqyVW6mbcGmhY4F0QhuzhjAOZ7GNVNgc=;
        b=FywowxeurSeaGDa5duq1ftn8sOqBPP00bB5ukXDGjb4V1OrPvFHQMt1uUB2XDjoXTq
         DvZYOuBDDU56keRx2JeNzL7qEo2WLkGOKUUhkRxYEOoKqequf2oRQ2JVRTgfp9SX2HM0
         WyrYELef12gbhGmh9YoLkfFfg3xx02XrkgASArieiy9UGJPIJN8Wvws8YnGF+80rfctE
         chc21Ozp4f5JxtSIHpGRFF/jJ4B0Jt1FFTzUHVPt/213FARIvuGzprY9yiETS4B0xjSb
         EbF9cKkdt0dzLufLQLehzQ5KOE0zDLyNXdElUaDB+dVzyT6H7Q1pUdJQpWLftCupbgQf
         pQOQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=lRdDK7qYLK/zqyVW6mbcGmhY4F0QhuzhjAOZ7GNVNgc=;
        b=jLduP/uTz9XZofkX1/bGxeprCwiMUMAeM4noCqAifwtxOaB088ZYRMRHoFCYMd2PPV
         vHD7pPewDR7+1/HnQUSKAnEylEPLtsb6WxtrvBcAxhJrGjMd21ISpxVD71Hfmx7EXvS1
         EqKIvr2rOd1dMOxj7r3nKBuiDEEWt0CNAMuP2nApSzlfQrbtqh8Fnj4hjEKy8kRe7Mrs
         qaPMXaI63eIwg4yPs39/SxDmz0lo+ikM2nx5yM5NFeu58n6/kvEJvBCIDOhLTRY5wxjV
         WAr+okVkUC75egzU8skjVmRywOWxpDraKswGND9BNW18UEphIbxH5L66m4HTU0Or9tOi
         54dw==
X-Gm-Message-State: APjAAAWU4kaSsgpC1Fir5qrG16ebGPKgDusGG0a7KbYYVkdk+hpHfMPP
	FJwbyikj6Qv7T0ve801+TNVQlmI5IhC75qVADB2JDw==
X-Google-Smtp-Source: APXvYqxhDG0WHFs4ohm1/qDVIbJ+d7Xa7W4rFB5i9zzal8+HoDkf0/3puu/ujrD5MqitgZRwuiVyrZKE6/Xz2hBD7Lw=
X-Received: by 2002:a7b:cf37:: with SMTP id m23mr2452526wmg.53.1568708650265;
 Tue, 17 Sep 2019 01:24:10 -0700 (PDT)
MIME-Version: 1.0
References: <20190917061912.17420-1-zhichao.gao@intel.com> <CAKv+Gu_iyxTbf3mNa1QW6K+Qny1tp604WAoBOdSczk9tNOthAw@mail.gmail.com>
 <C0706E73DB8C124D9B9C38AA364E5D5E0562D3B0@SHSMSX106.ccr.corp.intel.com>
In-Reply-To: <C0706E73DB8C124D9B9C38AA364E5D5E0562D3B0@SHSMSX106.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 17 Sep 2019 09:23:44 +0100
Message-ID: <CAKv+Gu-2xAPPGeLegS_+Oy0Ve96_YURzp9RustcPNOpcnSSnyg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Wang, Jian J" <jian.j.wang@intel.com>, 
	"Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>, 
	"Gao, Liming" <liming.gao@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 17 Sep 2019 at 08:17, Zhang, Shenglei <shenglei.zhang@intel.com> wr=
ote:
>
> Hi Ard,
>
> That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c=
423aba174d).
> This patch only updates the file guid, which I thought has no risk. So I =
didn=E2=80=99t check the build result.
> I should double check the new guid used in the file. Liming has help send=
 a patch to fix this issue.
>

I understand.

Please don't push changes without making sure they actually build.

Thanks,
Ard.