From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"ayellet.wolman@intel.com" <ayellet.wolman@intel.com>,
"jian.j.wang@intel.com" <jian.j.wang@intel.com>,
"vanjeff_919@hotmail.com" <vanjeff_919@hotmail.com>,
"Jiewen.yao@intel.com" <Jiewen.yao@intel.com>,
Evan Lloyd <Evan.Lloyd@arm.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
Matteo Carlini <Matteo.Carlini@arm.com>
Subject: Re: Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds
Date: Fri, 8 Dec 2017 15:19:28 +0000 [thread overview]
Message-ID: <CAKv+Gu-37_-4eQoT=H5qnqK9YUb4uM8pu2Hwy+EzmpsB4Vq7ng@mail.gmail.com> (raw)
In-Reply-To: <DB5PR08MB10147269A91F98C0E2FEB88A9A300@DB5PR08MB1014.eurprd08.prod.outlook.com>
On 8 December 2017 at 15:15, Alexei Fedorov <Alexei.Fedorov@arm.com> wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=811:
>
> Alexei 2017-12-08 10:09:31 EST
>
> Changing InitializeCpuExceptionHandlers to InitializeCpuExceptionHandlersEx
> in commit a8ab14d355072241915d87de86770c0fde92cba9:
> (https://github.com/tianocore/edk2/commit/a8ab14d355072241915d87de86770c0fde92cba9#diff-66e03695da9fb9e92abf60445eb36af7)
>
> if (GuidHob != NULL) {
> VectorInfoList = (EFI_VECTOR_HANDOFF_INFO *) (GET_GUID_HOB_DATA(GuidHob));
> }
> - Status = InitializeCpuExceptionHandlers (VectorInfoList);
> + Status = InitializeCpuExceptionHandlersEx (VectorInfoList, NULL);
> ASSERT_EFI_ERROR (Status);
>
> breaks ARM/AARCH64 builds because InitializeCpuExceptionHandlersEx() is not
> implemented in ArmPkg\Library\ArmExceptionLib\ArmExceptionLib.c
>
Yes it is.
4cb21e1e728cebce5b9ec4a6509ec67598719ba0
ArmPkg/ArmExceptionLib: Add implementation of new API
prev parent reply other threads:[~2017-12-08 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 15:15 Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds Alexei Fedorov
2017-12-08 15:19 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-37_-4eQoT=H5qnqK9YUb4uM8pu2Hwy+EzmpsB4Vq7ng@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox