public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds
@ 2017-12-08 15:15 Alexei Fedorov
  2017-12-08 15:19 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Alexei Fedorov @ 2017-12-08 15:15 UTC (permalink / raw)
  To: edk2-devel@lists.01.org, ayellet.wolman@intel.com,
	jian.j.wang@intel.com, vanjeff_919@hotmail.com,
	Jiewen.yao@intel.com
  Cc: Evan Lloyd, leif.lindholm@linaro.org, Matteo Carlini,
	ard.biesheuvel@linaro.org

<mailto:Alexei.Fedorov@arm.com>https://bugzilla.tianocore.org/show_bug.cgi?id=811:

<mailto:Alexei.Fedorov@arm.com>
Alexei<mailto:Alexei.Fedorov@arm.com> 2017-12-08 10:09:31 EST

Changing InitializeCpuExceptionHandlers to InitializeCpuExceptionHandlersEx in commit a8ab14d355072241915d87de86770c0fde92cba9:
(https://github.com/tianocore/edk2/commit/a8ab14d355072241915d87de86770c0fde92cba9#diff-66e03695da9fb9e92abf60445eb36af7)

if (GuidHob != NULL) {
  VectorInfoList = (EFI_VECTOR_HANDOFF_INFO *) (GET_GUID_HOB_DATA(GuidHob));
}
-  Status = InitializeCpuExceptionHandlers (VectorInfoList);
+  Status = InitializeCpuExceptionHandlersEx (VectorInfoList, NULL);
ASSERT_EFI_ERROR (Status);

breaks ARM/AARCH64 builds because InitializeCpuExceptionHandlersEx() is not implemented in ArmPkg\Library\ArmExceptionLib\ArmExceptionLib.c


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds
  2017-12-08 15:15 Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds Alexei Fedorov
@ 2017-12-08 15:19 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 15:19 UTC (permalink / raw)
  To: Alexei Fedorov
  Cc: edk2-devel@lists.01.org, ayellet.wolman@intel.com,
	jian.j.wang@intel.com, vanjeff_919@hotmail.com,
	Jiewen.yao@intel.com, Evan Lloyd, leif.lindholm@linaro.org,
	Matteo Carlini

On 8 December 2017 at 15:15, Alexei Fedorov <Alexei.Fedorov@arm.com> wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=811:
>
> Alexei 2017-12-08 10:09:31 EST
>
> Changing InitializeCpuExceptionHandlers to InitializeCpuExceptionHandlersEx
> in commit a8ab14d355072241915d87de86770c0fde92cba9:
> (https://github.com/tianocore/edk2/commit/a8ab14d355072241915d87de86770c0fde92cba9#diff-66e03695da9fb9e92abf60445eb36af7)
>
> if (GuidHob != NULL) {
>   VectorInfoList = (EFI_VECTOR_HANDOFF_INFO *) (GET_GUID_HOB_DATA(GuidHob));
> }
> -  Status = InitializeCpuExceptionHandlers (VectorInfoList);
> +  Status = InitializeCpuExceptionHandlersEx (VectorInfoList, NULL);
> ASSERT_EFI_ERROR (Status);
>
> breaks ARM/AARCH64 builds because InitializeCpuExceptionHandlersEx() is not
> implemented in ArmPkg\Library\ArmExceptionLib\ArmExceptionLib.c
>

Yes it is.

4cb21e1e728cebce5b9ec4a6509ec67598719ba0
ArmPkg/ArmExceptionLib: Add implementation of new API


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-08 15:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-08 15:15 Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds Alexei Fedorov
2017-12-08 15:19 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox