From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22c; helo=mail-it0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4482B2217CE4E for ; Fri, 8 Dec 2017 07:14:54 -0800 (PST) Received: by mail-it0-x22c.google.com with SMTP id u62so5518507ita.2 for ; Fri, 08 Dec 2017 07:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8WlGrXQszlM14vfid5z+qfvG7ATjXc7dO/m1FuQU81k=; b=NYHS1/mzFFKgP2iiV91+pTND0F+ldZPwZd6H7d9L3up46EnulIsWPHTiOnexRGrWMd 7GQMcU9P0k0V/ocIO7S6C9h/ApLc0Jv5apjzlu6Pi324hS/yKb53MTuqY/jjpWWLxQGc HUTrK7heGJBEJJboqlUZWcDW5WPJ6hDBZjucY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8WlGrXQszlM14vfid5z+qfvG7ATjXc7dO/m1FuQU81k=; b=DaFVVknv0uK6BhMbry0yB2eHQx+zsWE2ypkUBaulKXlaQEhAWeR8ZeKdWh0vxEX9C5 pNm4XhefMeUq4zCbUg9r/a70yPDTMp0VaLglc+2b/V7lnq2zW9zq3UqUmDM++qSe1UdQ vpIxyp1hGgTkOfBr/P4suGB4F6Wgke3f7h/kZMAt/x246Ga5D/vA/zGbpGONc1CFcGoH aKbCMTM+5S+CGu+YgsJ0UZjYFB1jqwsf69SdDIKlScxeh2umtB/nldFrYp4VJuTr7X9u 3spFB2IX/fmJlCwCetthLSOE4eufAYuqzxM85E0Qg87Fxv1+6Y4ssBTvrUaxUFtGTjEq b5Dg== X-Gm-Message-State: AKGB3mIQ4ohgj5BS6ctfBf1KQddAYrmrSjVp9bIDqGK3CTG0Cij+q5a4 +8074OC/drMfhJqFN7YGVvxBEKV2YVTNfPp/IIuW5Q== X-Google-Smtp-Source: AGs4zMa6DIewF2thJSVBN8doEbU68JMbA78pxWArSMIaC1qDlAPKk24eBPREYjbnGBK9euxhJPCVGxiCJD9/uuwV0Os= X-Received: by 10.36.78.212 with SMTP id r203mr6294235ita.58.1512746368763; Fri, 08 Dec 2017 07:19:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Fri, 8 Dec 2017 07:19:28 -0800 (PST) In-Reply-To: References: From: Ard Biesheuvel Date: Fri, 8 Dec 2017 15:19:28 +0000 Message-ID: To: Alexei Fedorov Cc: "edk2-devel@lists.01.org" , "ayellet.wolman@intel.com" , "jian.j.wang@intel.com" , "vanjeff_919@hotmail.com" , "Jiewen.yao@intel.com" , Evan Lloyd , "leif.lindholm@linaro.org" , Matteo Carlini Subject: Re: Commit a8ab14d of DxeMain.c in MdeModulePkg breaks ARM/AARCH64 builds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 15:14:55 -0000 Content-Type: text/plain; charset="UTF-8" On 8 December 2017 at 15:15, Alexei Fedorov wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=811: > > Alexei 2017-12-08 10:09:31 EST > > Changing InitializeCpuExceptionHandlers to InitializeCpuExceptionHandlersEx > in commit a8ab14d355072241915d87de86770c0fde92cba9: > (https://github.com/tianocore/edk2/commit/a8ab14d355072241915d87de86770c0fde92cba9#diff-66e03695da9fb9e92abf60445eb36af7) > > if (GuidHob != NULL) { > VectorInfoList = (EFI_VECTOR_HANDOFF_INFO *) (GET_GUID_HOB_DATA(GuidHob)); > } > - Status = InitializeCpuExceptionHandlers (VectorInfoList); > + Status = InitializeCpuExceptionHandlersEx (VectorInfoList, NULL); > ASSERT_EFI_ERROR (Status); > > breaks ARM/AARCH64 builds because InitializeCpuExceptionHandlersEx() is not > implemented in ArmPkg\Library\ArmExceptionLib\ArmExceptionLib.c > Yes it is. 4cb21e1e728cebce5b9ec4a6509ec67598719ba0 ArmPkg/ArmExceptionLib: Add implementation of new API