public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Gao, Liming" <liming.gao@intel.com>,
	 "Wang, Jian J" <jian.j.wang@intel.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 5/7] ArmPkg/ArmSoftFloatLib: add SPDX identifiers
Date: Tue, 28 May 2019 13:28:21 +0200	[thread overview]
Message-ID: <CAKv+Gu-3w1w6SjO6HXGP-cRNEiPwfKqVJCgmznzJJcq6UZNuQg@mail.gmail.com> (raw)
In-Reply-To: <70500072-4a70-bbc3-f939-8e9b42a2b365@redhat.com>

On Tue, 28 May 2019 at 13:27, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 05/27/19 22:51, Ard Biesheuvel wrote:
> > Add the appropriate SPDX identifiers to all files taken from the
> > 3-clause BSD licensed SoftFloat library.
> >
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1845
> > Acked-by: Jian J Wang <jian.j.wang@intel.com>
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h    | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ARM-VFPv2/s_propagateNaNF64UI.c  | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ARM-VFPv2/softfloat_raiseFlags.c | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ARM-VFPv2/specialize.h           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_add.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_div.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_eq.c                         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_le.c                         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_lt.c                         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_mul.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_sub.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_to_f64.c                     | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_to_i32_r_minMag.c            | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_to_i64_r_minMag.c            | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_to_ui32_r_minMag.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f32_to_ui64_r_minMag.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_add.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_div.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_eq.c                         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_le.c                         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_lt.c                         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_mul.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_sub.c                        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_to_f32.c                     | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_to_i32_r_minMag.c            | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_to_i64_r_minMag.c            | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_to_ui32_r_minMag.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/f64_to_ui64_r_minMag.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/i32_to_f32.c                     | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/i32_to_f64.c                     | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/i64_to_f32.c                     | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/i64_to_f64.c                     | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/include/internals.h              | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/include/opts-GCC.h               | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/include/primitiveTypes.h         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/include/primitives.h             | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/include/softfloat.h              | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/include/softfloat_types.h        | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_addMagsF32.c                   | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_addMagsF64.c                   | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_countLeadingZeros32.c          | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_countLeadingZeros64.c          | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_countLeadingZeros8.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_mul64To128.c                   | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_normRoundPackToF32.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_normRoundPackToF64.c           | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_normSubnormalF32Sig.c          | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_normSubnormalF64Sig.c          | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_roundPackToF32.c               | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_roundPackToF64.c               | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_shiftRightJam32.c              | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_shiftRightJam64.c              | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_shortShiftRightJam64.c         | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_subMagsF32.c                   | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/s_subMagsF64.c                   | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/softfloat_state.c                | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ui32_to_f32.c                    | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ui32_to_f64.c                    | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ui64_to_f32.c                    | 1 +
> >  ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/source/ui64_to_f64.c                    | 1 +
> >  60 files changed, 60 insertions(+)
> >
> > diff --git a/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h b/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h
> > index 18ed054d4f4d..2a750e4f540e 100644
> > --- a/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h
> > +++ b/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h
> > @@ -1,5 +1,6 @@
> >
> >  /*============================================================================
> > +SPDX-License-Identifier: BSD-3-Clause
> >
> >  This C header file is part of the SoftFloat IEEE Floating-Point Arithmetic
> >  Package, Release 3e, by John R. Hauser.
>
> We generally replace the original license text with the SPDX identifier.
> But, I guess we can do that later here.
>

No, we can't. The license does not actuall permit that ...

  reply	other threads:[~2019-05-28 11:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 20:51 [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version Ard Biesheuvel
2019-05-27 20:51 ` [PATCH v2 1/7] ArmPkg: import latest version (3e) of the Berkeley Softfloat library Ard Biesheuvel
2019-05-27 20:51 ` [PATCH v2 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library Ard Biesheuvel
2019-05-27 20:51 ` [PATCH v2 3/7] ArmPkg/ArmSoftFloatLib: remove source files that are no longer used Ard Biesheuvel
2019-05-27 20:51 ` [PATCH v2 4/7] ArmPkg/ArmSoftFloatLib: remove new source files that are not used Ard Biesheuvel
2019-05-27 20:51 ` [PATCH v2 5/7] ArmPkg/ArmSoftFloatLib: add SPDX identifiers Ard Biesheuvel
2019-05-28 11:27   ` Laszlo Ersek
2019-05-28 11:28     ` Ard Biesheuvel [this message]
2019-05-28 12:22       ` Leif Lindholm
2019-05-27 20:51 ` [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard Ard Biesheuvel
2019-05-28  0:17   ` Liming Gao
2019-05-28  6:10     ` [edk2-devel] " Ard Biesheuvel
2019-05-28  7:37       ` Wang, Jian J
2019-05-28  8:25       ` Leif Lindholm
2019-05-27 20:51 ` [PATCH v2 7/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S Ard Biesheuvel
2019-05-30  9:24   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-05-28  6:35 ` [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version Ard Biesheuvel
2019-05-28 11:21 ` Laszlo Ersek
2019-05-28 11:29 ` Laszlo Ersek
2019-05-28 11:39 ` Laszlo Ersek
2019-05-28 13:56   ` Ard Biesheuvel
2019-05-28 16:57   ` [edk2-devel] " Michael D Kinney
2019-05-28 15:40 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-3w1w6SjO6HXGP-cRNEiPwfKqVJCgmznzJJcq6UZNuQg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox