From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 180F92222C24E for ; Fri, 26 Jan 2018 09:25:55 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id 68so2501285ite.4 for ; Fri, 26 Jan 2018 09:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qX0yXXWOWP+i2pU6PdbqvL37BBjKzYQcemFfSN05Abk=; b=fKKi4hP9YUO/wSBCk3mXOi+mHyMr1y8puI0YdZnNhkrS7pAD6Gp9XhpdTQ42KEIrfG hxFhsVgvCDUBgYQfD1nwoP+2quk6xtfrQ5SupBTd6ThRMs1a0M9qTxKcf/WI0+FAg4Mq bq9ZsZwmQ4l8GxDFqg29TBCQIKJT1aeGZOcAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qX0yXXWOWP+i2pU6PdbqvL37BBjKzYQcemFfSN05Abk=; b=hxqJI6Lz62N1HepfxeYkMLFOvZD1fNZFKL9+yAL7xQQ+lD0760nnrJee08BIkkmGSi kuRRpMTbpx2IuBB/K9yDGZzsIXHDfR/a/Wz9Q5cq+gV9acdDTQxRHVQssK8R8uAujKDK wdy9f7vTw46WSE0qHJdKSfoJWQemZy9Xsdg0rNpITEHj3Y8gZ0nWdE2Cb5ruYpZUMHOJ DYk1tSyrpKVphzZyIc41pbD2JqomuQF7X23ttYI55CpVeJCQGXMCGzD/0c7J+ya2S4/5 Brw64euQH7O1B6Y53oLAKXMSpjsEZd3l4xEhv+dmuPfjIGp10ZmQQJCw38go4PlAOG/o xVuw== X-Gm-Message-State: AKwxyteG1c3WobLhDcHJ2/MwV/sRCrp3TDwiOFI3Q3YaRObrZaOXTfVl 368cfAnLKfuGeBXi+ZM/UC3P6ML04hR4G6gcLayhwQ== X-Google-Smtp-Source: AH8x227HAOMKky0+2zjkVzgReBOGrp7Rq3YXXBqoZbjkT1c1KM9E9odls6TXVQcUcG5QDO6xuLVFn73p9qOff3fVytQ= X-Received: by 10.36.7.9 with SMTP id f9mr17216872itf.143.1516987885578; Fri, 26 Jan 2018 09:31:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Fri, 26 Jan 2018 09:31:25 -0800 (PST) In-Reply-To: <20180126173006.17324-1-leif.lindholm@linaro.org> References: <20180126173006.17324-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Fri, 26 Jan 2018 17:31:25 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:25:56 -0000 Content-Type: text/plain; charset="UTF-8" On 26 January 2018 at 17:30, Leif Lindholm wrote: > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of > the unfortunate ARM-specific variant of PcdFirmwareVendor. > > However, BeagleBoard was still using it, so the change broke the build. > Fix this by moving BeagleBoard to use the MdeModulePkg one instead. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index 5d87ee3891..cef2e095d4 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > > [PcdsFixedAtBuild.common] > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" That should probably be L"Beagle Board" > > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > -- > 2.11.0 >