From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A2B4E224A9EA6 for ; Fri, 30 Mar 2018 03:56:02 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id q84so10721268iod.10 for ; Fri, 30 Mar 2018 03:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Wo3bDzwUJRr/NDH4WxKOouO1Xcs+ggbwPAGPHkKoxr8=; b=W9IClR9ZLwH6X5xf91qII/ucKg792sUgk58u28MVRaeLDO8opw2RF7I7cy93+QJdNl x+gLKzHQycFV9GPWxw7IPisIyFe8+1qVvbLglheVKq4F9zCnGxSC5RZRVQKeYwJm9UmR A7h5CfjXv8nlxB3YeQGjf1e69/kHHvOeepftU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Wo3bDzwUJRr/NDH4WxKOouO1Xcs+ggbwPAGPHkKoxr8=; b=YE8FHLyTGqlly+dHeVJrDD77F6TVUDVlWvX5x3aVOoIt1AluCF73TwfvzzEbnJPPOP sv+P23cL0moFJhVBeS9eBk9z1GWe38/l+yUcG5rgeyCB4qWNggpjXHGNexw8fUeXIgGy Uggr2b2DxuG+YfyfFyG1UUf9UDQnHzXiViK18J9CAqU5nLYzzQWjMcP4ypQLRMzlWauA xL1N5WlmdLEHfD7OGAw0COvjAgTE0UanHgXOK5o7b8PU+zbyKaZE9A7BEkGQbj3wgChI Mr2tEoG6CWCXnyjfYktLvVuwXeGYmQCPu1VCgUp6lB5EAQydr4JqfvGa6FDwSJC1bya6 bbvQ== X-Gm-Message-State: AElRT7EeKHSFLkF2OHTaWmpgq+g1aeCWOkcxP0emkyJfjpDFfQiWJ4CW H8DCTm4TGzluEkGQp6uvddOvH9Hv/ItNlEDBMaP2Ag== X-Google-Smtp-Source: AG47ELtZ7XPp2tPY5UYGt4VtTbFp9TNkYln0umzwvyScs22X3ytTGRmZzyZ5gEsgSKZ84uPU7mElzsbo8BMP31oSyC8= X-Received: by 10.107.14.136 with SMTP id 130mr44012982ioo.170.1522407361452; Fri, 30 Mar 2018 03:56:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 30 Mar 2018 03:56:01 -0700 (PDT) In-Reply-To: <20180329000612.GA97590@SZX1000114654> References: <1522052735-68033-1-git-send-email-heyi.guo@linaro.org> <1522052735-68033-2-git-send-email-heyi.guo@linaro.org> <20180329000612.GA97590@SZX1000114654> From: Ard Biesheuvel Date: Fri, 30 Mar 2018 11:56:01 +0100 Message-ID: To: Guo Heyi Cc: "edk2-devel@lists.01.org" , Yi Li , Leif Lindholm , Michael D Kinney Subject: Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 10:56:02 -0000 Content-Type: text/plain; charset="UTF-8" On 29 March 2018 at 01:06, Guo Heyi wrote: > Ah, I made the change locally but forgot to send it out... > > Now it is there :) > Thanks. Do you have a repo link for the binary patch? > On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: >> On 26 March 2018 at 10:25, Heyi Guo wrote: >> > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it >> > is not necessary to maintain two different binary images for D03 and >> > D05 respectively. >> > >> > The main difference between D03 and D05 is the implementation of >> > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So >> > we switch to null DebugLib for release build and get a unified >> > Sm750Dxe binary. >> > >> > The code in SM750 driver treated the address returned from >> > PciIo->GetBarAttributes() as device address; this should be fixed >> > after edk2 commit dc080d3 since GetBarAttributes() returns host >> > address from then on. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Heyi Guo >> > Signed-off-by: Yi Li >> > Cc: Ard Biesheuvel >> > Cc: Leif Lindholm >> > Cc: Michael D Kinney >> >> Reviewed-by: Ard Biesheuvel >> >> Obviously, this requires a matching update in edk2-platforms, so >> please send that out and we can apply both at the same time. >> >> >> > --- >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- >> > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes >> > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes >> > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes >> > 5 files changed, 32 deletions(-) >> > >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> > deleted file mode 100644 >> > index a2618331440f..000000000000 >> > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> > +++ /dev/null >> > @@ -1,32 +0,0 @@ >> > -#/** @file >> > -# >> > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. >> > -# Copyright (c) 2016, Linaro Limited. All rights reserved. >> > -# >> > -# This program and the accompanying materials >> > -# are licensed and made available under the terms and conditions of the BSD License >> > -# which accompanies this distribution. The full text of the license may be found at >> > -# http://opensource.org/licenses/bsd-license.php >> > -# >> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> > -# >> > -#**/ >> > - >> > - >> > -[Defines] >> > - INF_VERSION = 0x00010005 >> > - BASE_NAME = SmiGraphicsOutput >> > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 >> > - MODULE_TYPE = UEFI_DRIVER >> > - VERSION_STRING = 1.0 >> > - >> > - PCI_VENDOR_ID = 0x126F >> > - PCI_DEVICE_ID = 0x0750 >> > - PCI_CLASS_CODE = 0x030000 >> > - PCI_REVISION = 0xA1 >> > - COMPRESS = TRUE >> > - >> > -[Binaries] >> > - PE32|SmiGraphicsOutput.efi|* >> > - >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> > similarity index 100% >> > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf >> > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> > deleted file mode 100644 >> > index 16c91e2b18ef..000000000000 >> > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> > deleted file mode 100644 >> > index b8de0259c785..000000000000 >> > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> > new file mode 100644 >> > index 000000000000..3ae8ddfb647f >> > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ >> > -- >> > 2.7.4 >> >