From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=WeKG4/Id; spf=pass (domain: linaro.org, ip: 209.85.166.196, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) by groups.io with SMTP; Wed, 29 May 2019 08:20:56 -0700 Received: by mail-it1-f196.google.com with SMTP id e184so4195861ite.1 for ; Wed, 29 May 2019 08:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2IdMg47jDDzDpX0K7NDQEE3XcDDhWH0wTeJp7Mou3bs=; b=WeKG4/IdPMEgHxCy/crGorEFEAymt7dYrN3yTReDSPICvOSgG5Dhkon+wLjM4AroWt K5KJQLSkdTG8mnYFXA65FDXCLOMFQT2fvj75yqDJvdQSdZW0skUK9f7+67Crzo9yYNxa 8B22PmOsIw9dEQT1nJqwRR4x9tJZlXI579+KhrIqlNMYONF93xKqALGrvpxwlLrq0vFt DL8REZQfwGLhmf8cheNoODRi497YG7JdEAUQDEZsR5X1BHNpPZ6yQ1vyaMI3B2OwSHKJ 0zq2lE1MwgWKlWLsJCN1Iy7jrl1tmbZIHN+5CS42DdEqgpNWIy+DDeyE2lVY8Pcnek37 ipxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2IdMg47jDDzDpX0K7NDQEE3XcDDhWH0wTeJp7Mou3bs=; b=U7SeNTp3qErkk1O/opgDsnlzbxK4ao7uHJqEpKzX92clKQRmkxQlvTcQMs+7hnPvrU B9JMoUHf51isKd4uUMz0/BPBV35e6OUmplpW6Xb0ZW8ePq+hbJ8VE4GJiSO/59wUFIm/ XzLHtxTEeqwIwaadTBIvPzmt+Rkc0pBliWE0iK7YgyS5BZXW4n4ps8ncxr1VDhXqozuN /RDaSf8pEqvxFqwHWh89ObyrVCrgUE+o7+K93OXQOAnzr0QLPq9iCqSHv61D+dtoGuuA +6tkMVIOolKOZRDX1r1Yb6gvtKxUYy1/84Gqwlj5GUEGTILw+IfHYIvGrIT8DdOdhIp0 uRsA== X-Gm-Message-State: APjAAAU8cq5J44TzUDUr0VR+YzU8rjY7qY7kl2NNUvcI2O+P/GiKL/yG ZL9yE4TXmgRCCZL/A8NCDQhbnZALGPPfLby1pQdbMw== X-Google-Smtp-Source: APXvYqw4qOO0V3AqLRWJvuvipfAtKQuL3mxV/zmq+sZtxlnNJhcQgrraOGJlFZ5RHfeh0t5d6YplkDz38GqjPrKdZFk= X-Received: by 2002:a02:a494:: with SMTP id d20mr6596065jam.62.1559143250948; Wed, 29 May 2019 08:20:50 -0700 (PDT) MIME-Version: 1.0 References: <20190529151209.17503-1-lersek@redhat.com> In-Reply-To: <20190529151209.17503-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Wed, 29 May 2019 17:20:38 +0200 Message-ID: Subject: Re: [PATCH for-edk2-stable201905 0/6] work around a QEMU issue triggered by the original TianoCore#1814 fix To: Laszlo Ersek Cc: edk2-devel-groups-io , Gerd Hoffmann , Jordan Justen Content-Type: text/plain; charset="UTF-8" On Wed, 29 May 2019 at 17:12, Laszlo Ersek wrote: > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1859 > Repo: https://github.com/lersek/edk2.git > Branch: exbar_mtrr_bz_1859 > > The fix (commit range 3b7a897cd8e3..39b9a5ffe661) for > is technically > correct, but it tickles an (arguably unjustified) assumption in QEMU the > wrong way. For end users, this makes the original fix for TianoCore#1814 > a regression, under certain circumstances. > > In theory, the assumption should be eliminated in QEMU, but in practice, > that could be quite intrusive and/or take long. It seems possible to > work around the problem in OVMF, satisfying the assumption again; for > that, OVMF needs a different fix (and a different trade-off) for the > original problem described in TianoCore#1814. > > Please see the detailed problem statement and the workaround's idea in > TianoCore#1859. > > If possible, I'd like to get this into edk2-stable201905 (which we're > postponing by two weeks anyway, for the sake of the OpenSSL 1.1.1b > upgrade). > > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jordan Justen > For the series, Acked-by: Ard Biesheuvel I think the reverts obviously belong in the stable tag, and I don't see why we shouldn't include the other two patches as well. > Laszlo Ersek (6): > Revert "OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many > bits clear" > Revert "OvmfPkg/PlatformPei: reorder the 32-bit PCI window vs. the > PCIEXBAR on q35" > Revert "OvmfPkg/PlatformPei: hoist PciBase assignment above the > i440fx/q35 branching" > Revert "OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 > branches explicitly" > OvmfPkg: raise the PCIEXBAR base to 2816 MB on Q35 > OvmfPkg/PlatformPei: set 32-bit UC area at PciBase / PciExBarBase > (pc/q35) > > OvmfPkg/OvmfPkgIa32.dsc | 5 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 5 +- > OvmfPkg/OvmfPkgX64.dsc | 5 +- > OvmfPkg/PlatformPei/Platform.h | 5 ++ > OvmfPkg/PlatformPei/MemDetect.c | 70 +++++++++++++++----- > OvmfPkg/PlatformPei/Platform.c | 17 +++-- > 6 files changed, 80 insertions(+), 27 deletions(-) > > -- > 2.19.1.3.g30247aa5d201 >