From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=BIkdHGFH; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Mon, 16 Sep 2019 04:18:10 -0700 Received: by mail-wr1-f67.google.com with SMTP id h7so37419921wrw.8 for ; Mon, 16 Sep 2019 04:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2ni6gCzv+0hSFWfjv283b4zmlPR3mvX0PTNdZo+tNto=; b=BIkdHGFHr1LcCJUV/r2BZnME3HyiEipnWOqayJjvnuYYsosUbVA6izg0ZYvNXpHGCY EB7c48ss2MyRi21oTLNHgbyfWRqRqZ/3ANSHs4WsJ7CRXTkhDm+/Oi2DVzRUS/JvQPe1 je0lzLHj+lZoBOapi1FpKFZtHvoQquSRNe2coOPN1x5oOMCqzSldcj1uNcPcYRUW6Jtq q3T5gzkWJnlMlTyO9LkXkDd5axXfLMvqOQNN2/1Su7B9ZcFrKK2UovgXxY/X/H4Q3hKP NfzJcApsmv3dw+owS5i/JTI7PJopsk57mfTBD9bRP9W8wHY4Q+Agd8f2ymVgwfcevzcZ hUQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2ni6gCzv+0hSFWfjv283b4zmlPR3mvX0PTNdZo+tNto=; b=JUxzXoSQxNrHBpJAYpeoIzfMc3H1knXhQm5zC8ZVwEZvMkiW6WB0KvuRsN4bZ2tbHF 74DGAMkerkoaroN4RWgki2SXVacCi8kuxPGfbvO1Yl9d74FrHXoUI3vL8o0Z+ipgSkyg FLZ0DfeSGuSHeUJVEiKZTVs0Q1jDr4aZEyrZYj5y767pflAGKiTtTd2dgOrmk7V4qdo3 G84zkw2BazUCwjBxw5y5EbHEsQ4drtKT1hnrlxMbkuQMO7duaCnezRBq05glybRv36nF 6063Y308SssRr3G+uQJULhfN7zx4j4sn9vmXfAry4sDiBMlcT4XHrgKnKm5zsT8TWzP4 Boew== X-Gm-Message-State: APjAAAVatqMI30/Sv4783iPiXWynMf2C5kVARYRlbLSyof/MqI1CjFrK p5EdQNF4hhbT6/dj/XFQdwFoygJTdQG2UGUbehgZGg== X-Google-Smtp-Source: APXvYqxlkmPL6cyyl9iBhin7GHVaBud7SDWVuBqNWBvrUKxPa+bLAIiRGsNtX/aV8p9uxqB0EzsB4V5/F81/kAz8uVs= X-Received: by 2002:adf:ee50:: with SMTP id w16mr14069456wro.93.1568632688524; Mon, 16 Sep 2019 04:18:08 -0700 (PDT) MIME-Version: 1.0 References: <20190913190445.9832-1-ard.biesheuvel@linaro.org> <3c8a28f6-d921-cde2-0195-08efce528701@redhat.com> In-Reply-To: <3c8a28f6-d921-cde2-0195-08efce528701@redhat.com> From: "Ard Biesheuvel" Date: Mon, 16 Sep 2019 12:17:44 +0100 Message-ID: Subject: Re: [PATCH] StandaloneMmPkg: make package .DSC file build again To: Laszlo Ersek Cc: edk2-devel-groups-io , Achin Gupta , "Yao, Jiewen" Content-Type: text/plain; charset="UTF-8" On Mon, 16 Sep 2019 at 12:13, Laszlo Ersek wrote: > > Hi Ard, > > On 09/13/19 21:04, Ard Biesheuvel wrote: > > The StandaloneMmPkg .DSC file went out of sync with the changes > > applied to the package when I enabled this code on the Synquacer > > platform in edk2-platforms. So apply the necessary changes to make > > this package build in isolation. > > > > Signed-off-by: Ard Biesheuvel > > --- > > StandaloneMmPkg/StandaloneMmPkg.dsc | 19 +++++++++++-------- > > 1 file changed, 11 insertions(+), 8 deletions(-) > > > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc > > index 8c5b9b3a3d47..8a68d397469b 100644 > > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > > @@ -39,29 +39,32 @@ > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > > FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf > > - HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > > + HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf > > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > > MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > > MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf > > + MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > + PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf > > - > > - # > > - # Entry point > > - # > > - StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > > + StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > > + StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > > > > [LibraryClasses.AARCH64] > > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > > StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > > ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > > - PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > > > > - StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > + > > +[LibraryClasses.common.MM_CORE_STANDALONE] > > + HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > > > > ################################################################################ > > # > > > > With this patch applied on top of 9b5a1c789d39, the DSC builds fine for > AARCH64. > > However, the DSC also advertizes IA32 and X64 in > "SUPPORTED_ARCHITECTURES", and those builds still fail, with: > > StandaloneMmPkg/StandaloneMmPkg.dsc(...): error 4000: Instance of > library class [CacheMaintenanceLib] is not found > in [StandaloneMmPkg/Core/StandaloneMmCore.inf] [IA32] > > Now, I'm not sure if *this* build breakage is related to the Synquacer > work you mention in the blurb. If it is, then fixing it would be nice. > If not, then can we perhaps remove IA32 and X64 from > SUPPORTED_ARCHITECTURES? > > If you end up reposting with IA32/X64 removed from > SUPPORTED_ARCHITECTURES, then, for that version: > > Reviewed-by: Laszlo Ersek > Jiewen should correct me if I am wrong, but as far as I know, StandaloneMmPkg is ARM-only in practice, even if the PI spec is arch agnostic about it.