From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 87E302217CE28 for ; Wed, 6 Dec 2017 12:32:18 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id 68so9295974ite.4 for ; Wed, 06 Dec 2017 12:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZuJxl9fe1vx2WZxfSXVKnDP59eiNS4AlD0BFEkoSO1w=; b=PjNrl/eBhtrq/DESnCtZIAfyfFi3NbnFZDGj4Yz7fFQJuQmUfTAk6J1DnvxK9lMIKS cLJVgImE2pgHn0YnagUUgiSxEbZla8kvGHRHkFTBUtirfkSSXNhWTir68HUxKwr4Kvpz kVrkkAIIEDq019QqO6MNyzshiZPMMKbhVCd1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZuJxl9fe1vx2WZxfSXVKnDP59eiNS4AlD0BFEkoSO1w=; b=sWtu7+RkMPUg7I5W+NmtACWr92EgGO5XlrnI8MyALqo0q/hqjDYV88e/fa1eECvCq5 CTTuqBQ4d8xrv4s6fZnjJseeD08O3EVOzmqihH4vFwwEl0UXUsA+Mn70ubFBgOut+gcA /JtZNG6znHino+C+CqHGYieBZ/NykAMpxA2ZlJqDQkrSqM3txuOWtehn4Uu+jCpPpn7o uzj54EWhOI/QuB30uR4ymKKStcHHlQHoibLOwIB++EMPk3WNx2j2jQzsGsNBK2J3M2bV ehUJ+BzZ6VCzdRLGZkxNsUrU1M3kcjhHns6NOTkZp9UPnmSEBZmOL8NPmDRzW3g/NvUh vvbA== X-Gm-Message-State: AJaThX50TppPcr3lF+0Hdle21FmUQ+pkDt9rUuQLXKOMfbXy7NdQcYgJ 25w1bcCx5u1S7MSYQ3tir87t0hSa8/mqgPwbPHb0hLdN X-Google-Smtp-Source: AGs4zMbX+3JIzSaTV063ADWkGKD704lfgOBONWzBx5RYL2jm+5pVNEV6x1167JD2V2TAjku66YcyJS2sL6ArpbKfLYo= X-Received: by 10.107.59.85 with SMTP id i82mr34003015ioa.253.1512592609532; Wed, 06 Dec 2017 12:36:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 6 Dec 2017 12:36:48 -0800 (PST) In-Reply-To: <20171206203130.8219-1-leif.lindholm@linaro.org> References: <20171206203130.8219-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Wed, 6 Dec 2017 20:36:48 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Jun Nie Subject: Re: [PATCH] EmbeddedPkg: AndroidBootApp: fix clang compilation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 20:32:18 -0000 Content-Type: text/plain; charset="UTF-8" On 6 December 2017 at 20:31, Leif Lindholm wrote: > Address an incorrect function prototype (using ; instead of ,) > in AndroidBootImg.h. > > Also restructure code slightly to avoid a "may be used uninitialized" > warning. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > EmbeddedPkg/Include/Protocol/AndroidBootImg.h | 4 ++-- > EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 9 +++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/EmbeddedPkg/Include/Protocol/AndroidBootImg.h b/EmbeddedPkg/Include/Protocol/AndroidBootImg.h > index 1c458d0255..cd3c42e858 100644 > --- a/EmbeddedPkg/Include/Protocol/AndroidBootImg.h > +++ b/EmbeddedPkg/Include/Protocol/AndroidBootImg.h > @@ -33,8 +33,8 @@ EFI_STATUS > typedef > EFI_STATUS > (EFIAPI *ANDROID_BOOTIMG_UPDATE_DTB) ( > - IN EFI_PHYSICAL_ADDRESS OrigDtbBase; > - OUT EFI_PHYSICAL_ADDRESS *NewDtbBase; > + IN EFI_PHYSICAL_ADDRESS OrigDtbBase, > + OUT EFI_PHYSICAL_ADDRESS *NewDtbBase > ); > > struct _ANDROID_BOOTIMG_PROTOCOL { > diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > index 09c4d924f1..2e50cedf6a 100644 > --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > @@ -357,12 +357,13 @@ AndroidBootImgUpdateFdt ( > if (EFI_ERROR (Status)) { > goto Fdt_Exit; > } > + > + Status = gBS->InstallConfigurationTable ( > + &gFdtTableGuid, > + (VOID *)(UINTN)NewFdtBase > + ); > } > > - Status = gBS->InstallConfigurationTable ( > - &gFdtTableGuid, > - (VOID *)(UINTN)NewFdtBase > - ); > if (!EFI_ERROR (Status)) { > return EFI_SUCCESS; > } > -- > 2.11.0 >