From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66])
 by mx.groups.io with SMTP id smtpd.web12.45574.1585555809475213214
 for <devel@edk2.groups.io>;
 Mon, 30 Mar 2020 01:10:09 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=qi1jIq/T;
 spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f66.google.com with SMTP id 65so20428432wrl.1
        for <devel@edk2.groups.io>; Mon, 30 Mar 2020 01:10:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=hxlYVElUfJ57Un2T15v3JBDIrSmRWJRyUeJiOAtMOVs=;
        b=qi1jIq/TP/5afrdK8pFs5+MHM5wyOq/yhKu3iB9XxlcIarovYJkGGY7hqqaZ17QgVM
         CtPcQcNcYlZ8gRb4lyAzsociRm0MDQUjxbdWTo+tVgpULFLHvT5PlHk/UCAGSQMFAzSy
         GEKYp0uO3vKTavis2NMAx/WZzTg69sDnaauRDqwrOwnh2SnGxWbQBUvRMMf60uvU2mFi
         CSoAlIpA63dcyMmyNTjxiPM5v4XH7vJtl42mSEpEtZAcBd5TWnNvZIgUeBsNfnTZSN3z
         YMGiPPx4crPDsMjPxhpdI2UDkXXKTyjzfA7vv5i63clyMMBeuqxNfD6HDpz0nDMGfBxZ
         TZMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=hxlYVElUfJ57Un2T15v3JBDIrSmRWJRyUeJiOAtMOVs=;
        b=ip8zIrO+yaV6JtU6gaXTkjZ1RnCKf4iwAOw/vOsQfS8vg5pGiJ8gBuNQ6J0SM8m3K+
         nQ8SVAQZkLYP1NeIURof6jCvLV61UY6BzharralIjjfU0Oevq0s1852hrpCFcVUR+mpa
         J4siLNHKIXocQlPmfoR3uEWU1nJbcLG5+9P21l+uLMLiWgT+gP+JFoGr3JpxeuFDf4Kv
         e2zK0J+gTDilq+lxvj6kihFFdaQ+aCqSojeBcONTp6YYOVqrxRX8WJOPFZNmPt9jGkQd
         79FaCaRCOvDi1YtCIhORPdKUZ5e1gUdlcO5hxGBh7MzhJj/tTX+VySCScWxoBIKcrDJw
         L0hA==
X-Gm-Message-State: ANhLgQ0ODJjpHXvQCVRoUGiv6W3z6fPZTHv/WwMlGqPubrX7W04j49qw
	ycxfxt0yibmg1IXnkPHMjfcWIJ7O3sky+aa0HlmBZXqfzMY=
X-Google-Smtp-Source: ADFU+vsNnqI9sX9hO0iteeHG1HSZkx7Mds2DYJZ8fJxy5GQ01Zq+A0OKdTafL4v1TlVPqfH0dKVXDUg7eWjIAz+PON8=
X-Received: by 2002:a5d:604a:: with SMTP id j10mr13266301wrt.126.1585555807765;
 Mon, 30 Mar 2020 01:10:07 -0700 (PDT)
MIME-Version: 1.0
References: <20200329151353.14096-1-sami.mujawar@arm.com> <20200329151353.14096-3-sami.mujawar@arm.com>
In-Reply-To: <20200329151353.14096-3-sami.mujawar@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 30 Mar 2020 10:09:56 +0200
Message-ID: <CAKv+Gu-6uFB4vyeDNgoA73pzgKKMbjEhmGFaOu5WG_E8BUz90g@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v2 02/16] DynamicTablesPkg: Fix missing local header warning
To: edk2-devel-groups-io <devel@edk2.groups.io>, Sami Mujawar <sami.mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, 
	"(Exiting) Leif Lindholm" <leif.lindholm@linaro.org>, Matteo Carlini <Matteo.Carlini@arm.com>, 
	Laura Moretta <Laura.Moretta@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Sun, 29 Mar 2020 at 17:14, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> The edk2 BaseTools report a warning if a local header file
> is not listed under the [Sources] section in the INF file.
>
> Add header files to the [Sources] section in the respective
> INF files to fix the warnings.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Notes:
>     v2:
>       Splitting patch series and re-submitting DynamicTablesPkg     [SAMI]
>       patches from https://edk2.groups.io/g/devel/message/46261
>
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 1 +
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf        | 3 ++-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf        | 1 +
>  3 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
> index b47a690dd72702a2d7157cbb21249ba1d01d08cd..56b69591ac52ca3ba51250dc01a0846b22442ce9 100644
> --- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
> +++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
> @@ -25,6 +25,7 @@ [Sources]
>    DeviceTreeTableFactory/DeviceTreeTableFactory.c
>    DynamicTableFactoryDxe.c
>    SmbiosTableFactory/SmbiosTableFactory.c
> +  DynamicTableFactory.h
>
>  [Packages]
>    MdePkg/MdePkg.dec
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
> index 3bbd0e7818c6172f9178b12a3d0960e2d298bca1..2f987e3b6d339d4b5f342cb52b8dc712cf4e585c 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  IORT Table Generator
>  #
> -#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
> @@ -18,6 +18,7 @@ [Defines]
>
>  [Sources]
>    IortGenerator.c
> +  IortGenerator.h
>
>  [Packages]
>    MdePkg/MdePkg.dec
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
> index 3cb13d7d8fd3df04f3e16cc6161d9736f7579a80..2c7d19513d6ceea29fd9f271f983a6cf6d2c1046 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
> @@ -18,6 +18,7 @@ [Defines]
>
>  [Sources]
>    PpttGenerator.c
> +  PpttGenerator.h
>
>  [Packages]
>    EmbeddedPkg/EmbeddedPkg.dec
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
> 
>