From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] EmbeddedPkg/FdtLib: incorporate missing overlay support
Date: Wed, 21 Feb 2018 10:54:34 +0000 [thread overview]
Message-ID: <CAKv+Gu-7HsqAtAx-KJPDGJh9P39F=3y9V+O+9UdAvqgKue9dUg@mail.gmail.com> (raw)
In-Reply-To: <20180215124940.w57gpaeca6t2kanx@bivouac.eciton.net>
On 15 February 2018 at 12:49, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Feb 15, 2018 at 10:34:28AM +0000, Ard Biesheuvel wrote:
>> Commit a099239015eb ("EmbeddedPkg/FdtLib: Update FdtLib to v1.4.5")
>> updated our FdtLib implementation to a more recent upstream version,
>> but omitted fdt_overlay.c due to its ambiguous licensing situation.
>> This has been resolved now, so take the latest upstream version of
>> the file (which received no other modifications in the mean time)
>> and add it to FdtLib.
>>
>> Note that fdt_overlay.c has a dependency on strtoul() which EDK does
>> not provide natively, so add a private implementation that wraps the
>> BaseLib routines that do roughly the same.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> LGTM
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Pushed as 44e6186eeadf
Thanks.
>> ---
>> EmbeddedPkg/Include/libfdt.h | 31 +
>> EmbeddedPkg/Library/FdtLib/FdtLib.inf | 6 +
>> EmbeddedPkg/Library/FdtLib/fdt_overlay.c | 914 ++++++++++++++++++++
>> EmbeddedPkg/Library/FdtLib/fdt_strtoul.c | 38 +
>> 4 files changed, 989 insertions(+)
prev parent reply other threads:[~2018-02-21 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 10:34 [PATCH] EmbeddedPkg/FdtLib: incorporate missing overlay support Ard Biesheuvel
2018-02-15 12:49 ` Leif Lindholm
2018-02-21 10:54 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-7HsqAtAx-KJPDGJh9P39F=3y9V+O+9UdAvqgKue9dUg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox