From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B19BB20954CAA for ; Wed, 21 Feb 2018 02:48:36 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id g21so1693976ioj.5 for ; Wed, 21 Feb 2018 02:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wL3OxHWu8uFlHCleu6QjSVoOG4ChgcK18DjhEComSww=; b=WtBQP2+E2MWjZM69aE6ah06iYAmsLae8uhTGBAPAJJiJBuM3DVv/NxukWWR7zd/a2T oA+6m33X3W2UdqOh60SV4ZCb12oxZyneg/2lX9wm5uDbYig2YmKHKfFWNw4Tm+fBurlx 2a7uSoo+1XbAhji0H5Ndq6SC38a6ahs1XFF7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wL3OxHWu8uFlHCleu6QjSVoOG4ChgcK18DjhEComSww=; b=CwNSjKJkAWnebrT9cwGZE96L7kRrU3cdr21bSBJABd7Gw3Tem5WdCmEfXdKMhfKoKh B13X1zDvwCnJKyGEQi9kUUG2jfZCXODzJpB58y1b6S5B0iKzeXsga8hwOyAUBdoP5fH8 znCF1Wt3eyGYBeAnEUfnvro5lhDp9xGXW152oH7zU51IHok73gdUyCDBjsv5BL4bRUz0 GxIW9C7syhWfD/D9FhG0oPh4MYPptp9e1JQwOyW5S1d7AeBfdhE38fJExgi3FUE5ctqE yagQvuS0ID/EwVVJaZrZ2mzwQTWsXmbH+3OROvoDYXZxH/QNDqV9uChaN6/kelN12gnp HByg== X-Gm-Message-State: APf1xPBWzCDNKgItAPIPsk/pXOgqSWdbTUm0bY7OCFIgEO6/BnjQM++v GYxnzcOI8gHuMwz/xn59jDEKM6ErdWSXSZE0HP8f0w== X-Google-Smtp-Source: AG47ELuOZqxKuVQhVesZ7I6zNsbDxHNu/RQVNM08W1G4m3QMQpC29IiKfXQbYUunUgE5Wx+wY93HefEZpQpgbuBhnwk= X-Received: by 10.107.41.16 with SMTP id p16mr3568101iop.173.1519210475512; Wed, 21 Feb 2018 02:54:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 21 Feb 2018 02:54:34 -0800 (PST) In-Reply-To: <20180215124940.w57gpaeca6t2kanx@bivouac.eciton.net> References: <20180215103428.25726-1-ard.biesheuvel@linaro.org> <20180215124940.w57gpaeca6t2kanx@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 21 Feb 2018 10:54:34 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] EmbeddedPkg/FdtLib: incorporate missing overlay support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 10:48:37 -0000 Content-Type: text/plain; charset="UTF-8" On 15 February 2018 at 12:49, Leif Lindholm wrote: > On Thu, Feb 15, 2018 at 10:34:28AM +0000, Ard Biesheuvel wrote: >> Commit a099239015eb ("EmbeddedPkg/FdtLib: Update FdtLib to v1.4.5") >> updated our FdtLib implementation to a more recent upstream version, >> but omitted fdt_overlay.c due to its ambiguous licensing situation. >> This has been resolved now, so take the latest upstream version of >> the file (which received no other modifications in the mean time) >> and add it to FdtLib. >> >> Note that fdt_overlay.c has a dependency on strtoul() which EDK does >> not provide natively, so add a private implementation that wraps the >> BaseLib routines that do roughly the same. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > LGTM > Reviewed-by: Leif Lindholm > Pushed as 44e6186eeadf Thanks. >> --- >> EmbeddedPkg/Include/libfdt.h | 31 + >> EmbeddedPkg/Library/FdtLib/FdtLib.inf | 6 + >> EmbeddedPkg/Library/FdtLib/fdt_overlay.c | 914 ++++++++++++++++++++ >> EmbeddedPkg/Library/FdtLib/fdt_strtoul.c | 38 + >> 4 files changed, 989 insertions(+)