From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::229; helo=mail-io0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1DBB21A10961 for ; Wed, 29 Nov 2017 22:41:06 -0800 (PST) Received: by mail-io0-x229.google.com with SMTP id d14so6397551ioc.5 for ; Wed, 29 Nov 2017 22:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wSpuzXEB1V8Fd2ZR0KTUylOVvcbcEzxQgiKG7EKo5oI=; b=aFzJynGR+yOH5VSsd8qCqMwnqOkCfp7wDBpeCzy9c7Q51zHbdYwBc8xpAvIACGZ8p1 kqpDCqcefFPVGJzo12VL5M1dqL0zXsx81qh1SiIHI04zzVsPQMr7IA6ROgl7j2fCiDPH 1V6sVplljMsHtVcEQ/uPOgJ8mf5k7mtaXbvkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wSpuzXEB1V8Fd2ZR0KTUylOVvcbcEzxQgiKG7EKo5oI=; b=LX+qvvT6IAkP2Jn/wEIQoTjwW/sQykMByqbp2AGry8slvqpM4h6zPYQDWGBZOh6EVI p3+0RABIonUDPi0Y4BogNg6Q+nuzh4BE1qp5mHUlJ5OTmx+khYk4ycM2Wt3fLKOC7glh yADI3KsyYHUN9UxYIz09gNASw7TVnp1NIxqPIvCNJXxlxu/UjPly+hACD5dngKzsDiY4 Ar/bERXlfsTsL8AU4Kd1oznfHNUyWFQXP3cIHDJrDKJ4EmUqpG6hHpGKGOI3TXrOWAae 3n1OuewEXKVU+4ydoKtxWtVOj2zTd0ohx5KHPUZ2RV+H7qXzYwimqdF4Pyv8+VcQPwAA czoQ== X-Gm-Message-State: AJaThX4jLgxgxbg247jLNrHOp/RHpGJw9dsBwRxfMVZWsoxfylkWHe+e kZQhzkgshsz9TPcfyr7pJMCuo5UBuVnIDnTt/4hvbg== X-Google-Smtp-Source: AGs4zMb80kI3d/Ow6b3dxckJOdsqgtMuiXcKE7ByLVT61Ujuj/TFXQAFJbRc1IcVCXqqIP46DvbNnUSLYeWr9agQJU0= X-Received: by 10.107.178.145 with SMTP id b139mr6629490iof.52.1512024330936; Wed, 29 Nov 2017 22:45:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 29 Nov 2017 22:45:30 -0800 (PST) In-Reply-To: References: <20171110135847.361-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103B9B461F@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9BDC79@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Thu, 30 Nov 2017 06:45:30 +0000 Message-ID: To: "Wu, Hao A" Cc: "Zeng, Star" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Kinney, Michael D" , "Gao, Liming" , "Tian, Feng" , "Dong, Eric" Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 06:41:06 -0000 Content-Type: text/plain; charset="UTF-8" On 30 November 2017 at 02:16, Wu, Hao A wrote: >> -----Original Message----- >> From: Zeng, Star >> Sent: Thursday, November 30, 2017 10:15 AM >> To: Wu, Hao A; Ard Biesheuvel >> Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D; Gao, >> Liming; Tian, Feng; Dong, Eric; Zeng, Star >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers >> >> Hao, >> >> IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru >> >> Right? > > Yes. Sorry for the typo. > > Best Regards, > Hao Wu > >> >> Thanks, >> Star Hello Hao, Star, Please check the link for an example producer of the SD/MMC override protocol https://lists.01.org/pipermail/edk2-devel/2017-November/017672.html Thanks, Ard. >> -----Original Message----- >> From: Wu, Hao A >> Sent: Thursday, November 30, 2017 10:11 AM >> To: Ard Biesheuvel >> Cc: Zeng, Star ; edk2-devel@lists.01.org; >> leif.lindholm@linaro.org; Kinney, Michael D ; >> Gao, Liming ; Tian, Feng ; Dong, >> Eric >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers >> >> > -----Original Message----- >> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> > Sent: Thursday, November 23, 2017 8:57 PM >> > To: Wu, Hao A >> > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; >> > Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric >> > Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers >> > >> > On 23 November 2017 at 12:55, Wu, Hao A wrote: >> > >> -----Original Message----- >> > >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> > >> Sent: Thursday, November 23, 2017 6:11 PM >> > >> To: Wu, Hao A >> > >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; >> > >> Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric >> > >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers >> > >> >> > >> On 13 November 2017 at 03:37, Wu, Hao A wrote: >> > >> >> -----Original Message----- >> > >> >> From: Zeng, Star >> > >> >> Sent: Monday, November 13, 2017 11:32 AM >> > >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org; >> > >> >> leif.lindholm@linaro.org; Kinney, Michael D >> > >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star >> > >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI >> > >> >> controllers >> > >> >> >> > >> >> Hao, >> > >> >> >> > >> >> Could you help do the evaluation on this RFC? >> > >> > >> > >> > Sure, I will take a look on this. >> > >> > >> > >> >> > >> Any feedback? >> > >> >> > > >> > > Hi Ard, >> > > >> > > Sorry for the delayed response. >> > > >> > > I am still collecting feedbacks internally to see if there are >> > > additional hook points needed or other features/services that can be >> > > added to the SD/MMC override protocol. >> > > >> > > I think it would be better for this protocol to be general when it >> > > is introduced, which might avoid changing the protocol frequently later. >> > > >> > > What is your thought on this? >> > >> > Thank you for bringing this up internally. I agree that we should >> > carefully consider potential use cases now and not later. >> >> Hi Ard, >> >> Could you help to share an code example of the consumer of this protocol for >> reference? >> >> Also, we think that it might be helpful to pass the pointer of the >> EFI_SD_MMC_PASS_THRU_PROTOCOL to the >> SD_MMC_OVERRIDE_INVOKE_HOOK service as an additional input parameter: >> >> typedef >> EFI_STATUS >> (EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) ( >> IN EFI_HANDLE ControllerHandle, >> IN UINT8 Slot, >> IN SD_MMC_OVERRIDE_HOOK HookType, >> IN EFI_SD_MMC_PASS_THRU_PROTOCOL PassThru >> ); >> >> The implementation of the service can decide whether to use the PassThru >> protocol. >> >> If more hook points will be later added to the SDHCI override protocol, they >> may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional >> commands to the host controller during initialization. >> >> Best Regards, >> Hao Wu >> >> > >> > Thanks, >> > Ard.