From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 98606820B6 for ; Mon, 27 Feb 2017 08:18:55 -0800 (PST) Received: by mail-io0-x230.google.com with SMTP id l7so21507007ioe.3 for ; Mon, 27 Feb 2017 08:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vATnbtPXmWUsW2HEOrct7y5d0FLZM51MV2/pxKJ4FZM=; b=NNFN6t4rrkcl+J1mQgsvX7bX26bhcHPBhHibWNPqyFk1dTTdrEVxDCJjeBIOPRdPHl eFsoKymVYQC3w1sLb83/wlUOnJECduqHSYKojlOwZretoCBmW8bwLL9XzbwWa0kLBB+r yJEfICXpcSyJJofYbRijN98ZjSkS7IFt+HqAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vATnbtPXmWUsW2HEOrct7y5d0FLZM51MV2/pxKJ4FZM=; b=uSsq1g5dJYieGvkwwooCrRMsuDzcbM07wK41t3NbjP+xp8BRd9bz2XIGLJd7ton0xd HyXNwI4xWcfGkm+YTcUNN7NNHGxaXANvNQhgQDjOhmbnrIRIu5+cqrCgAyh5NXsSNiji D0ppKgPT+p8GHkcBUJfRmAqY1Ye6GzS2wiu47aavFTZPEu/gnFbB8GDcAKF+16fEzo9E inNGDfOsELprerirzOithGl5Qf4hJONXZq5A/IHWPpTD4VOPx/QBOv82pAZRZxa6pXTT NTg8HtLtrRmmFDuSHwf82GqTwPlWA3IpRm+fk2BPylDtv6SK2YSfh0/1mG7Qlv3cEZ4u KWpQ== X-Gm-Message-State: AMke39m1o6GW5QVMQFTk3v+GEjsDQxow+b5Hmaz7vpHt4Cge+FDlS/58qmnIndKzhTjLtmIkeCeFyfcpmjUl8YOf X-Received: by 10.107.168.21 with SMTP id r21mr2208095ioe.45.1488212334757; Mon, 27 Feb 2017 08:18:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Mon, 27 Feb 2017 08:18:54 -0800 (PST) In-Reply-To: <20170227154401.GG16034@bivouac.eciton.net> References: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org> <20170227154401.GG16034@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 27 Feb 2017 16:18:54 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 16:18:55 -0000 Content-Type: text/plain; charset=UTF-8 On 27 February 2017 at 15:44, Leif Lindholm wrote: > On Fri, Feb 24, 2017 at 06:40:25PM +0000, Ard Biesheuvel wrote: >> This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with >> any remaining references to it in various platform .DSC files. It is >> no longer used now that we removed the virtual uncached pages protocol >> and the associated DebugUncachedMemoryAllocationLib library instance. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thank you both I missed this one diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index cc09d38910a2..d40ea69b072d 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmVirtPkg/ArmVirt.dsc.inc @@ -360,11 +360,6 @@ [PcdsFixedAtBuild.common] gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderCode|20 gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderData|0 - # - # ARM Pcds - # - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000 - !if $(SECURE_BOOT_ENABLE) == TRUE # override the default values from SecurityPkg to ensure images from all sources are verified in secure boot gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x04 so I will fold that in, if there are no objections. Thanks, Ard. >> --- >> ArmPkg/ArmPkg.dec | 1 - >> ArmVirtPkg/ArmVirtQemu.dsc | 5 ----- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- >> BeagleBoardPkg/BeagleBoardPkg.dsc | 5 ----- >> Omap35xxPkg/Omap35xxPkg.dsc | 5 ----- >> 5 files changed, 21 deletions(-) >> >> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec >> index 4fd7a5be5158..c4b4da2f95bb 100644 >> --- a/ArmPkg/ArmPkg.dec >> +++ b/ArmPkg/ArmPkg.dec >> @@ -84,7 +84,6 @@ [PcdsFixedAtBuild.common] >> # Using a FeaturePcd make a '(BOOLEAN) casting for its value which is not understood by the preprocessor. >> gArmTokenSpaceGuid.PcdVFPEnabled|0|UINT32|0x00000024 >> >> - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000080000000|UINT64|0x00000002 >> # This PCD will free the unallocated buffers if their size reach this threshold. >> # We set the default value to 512MB. >> gArmTokenSpaceGuid.PcdArmFreeUncachedMemorySizeThreshold|0x20000000|UINT64|0x00000003 >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index 8fe3c3816961..00cdd7c20201 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common] >> # Size of the region used by UEFI in permanent memory (Reserved 64MB) >> gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 >> >> - # >> - # ARM Pcds >> - # >> - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 >> - >> ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec) >> gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE >> >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index aa40374745af..8354b13ddb1a 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common] >> # Size of the region used by UEFI in permanent memory (Reserved 64MB) >> gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 >> >> - # >> - # ARM Pcds >> - # >> - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 >> - >> ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec) >> gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE >> >> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc >> index a71a01ac7723..87879c33fcd9 100644 >> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc >> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc >> @@ -368,11 +368,6 @@ [PcdsFixedAtBuild.common] >> # Shell. >> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> >> - # >> - # ARM Pcds >> - # >> - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 >> - >> gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 >> >> # GUID of the UEFI Shell >> diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc >> index ad7d9898c330..fc94ca7ed129 100644 >> --- a/Omap35xxPkg/Omap35xxPkg.dsc >> +++ b/Omap35xxPkg/Omap35xxPkg.dsc >> @@ -162,11 +162,6 @@ [PcdsFixedAtBuild.common] >> # OMAP Interrupt Controller >> gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000 >> >> - # >> - # ARM Pcds >> - # >> - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 >> - >> ################################################################################ >> # >> # Components Section - list of all EDK II Modules needed by this Platform >> -- >> 2.7.4 >>