Re: [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 27 February 2017 at 16:25, Laszlo Ersek <lersek@redhat.com> wrote:
> On 02/27/17 17:18, Ard Biesheuvel wrote:
>> On 27 February 2017 at 15:44, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>>> On Fri, Feb 24, 2017 at 06:40:25PM +0000, Ard Biesheuvel wrote:
>>>> This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with
>>>> any remaining references to it in various platform .DSC files. It is
>>>> no longer used now that we removed the virtual uncached pages protocol
>>>> and the associated DebugUncachedMemoryAllocationLib library instance.
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>
>>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>>
>>
>> Thank you both
>>
>> I missed this one
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index cc09d38910a2..d40ea69b072d 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -360,11 +360,6 @@ [PcdsFixedAtBuild.common]
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderCode|20
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderData|0
>>
>> -  #
>> -  # ARM Pcds
>> -  #
>> -  gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000
>> -
>>  !if $(SECURE_BOOT_ENABLE) == TRUE
>>    # override the default values from SecurityPkg to ensure images
>> from all sources are verified in secure boot
>>    gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x04
>>
>> so I will fold that in, if there are no objections.
>
> sure, go ahead
>

Pushed, thanks.