From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E6FD081F3A for ; Mon, 27 Feb 2017 08:39:30 -0800 (PST) Received: by mail-io0-x22a.google.com with SMTP id l7so21952312ioe.3 for ; Mon, 27 Feb 2017 08:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fVg6WoH1zTUHrIt2Mm0XmPnBcUAWJPs76/oikqYzvfQ=; b=Ce6CgFGEK4IVWHQ89RHmzP61mwayPA7sFE5fXCk0n7gMv7bz3y0O6zuqD7AGumHnlV YRDuFJpIJCvGTN1ogcXIcH3hSjl5O0Q3C7KquTYgmWk41ZAlbgorczZHou+EZn0xP86q CklW9Ro+Oabwg+Vdn+ul7Hlrfz504vdtC6Rb4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fVg6WoH1zTUHrIt2Mm0XmPnBcUAWJPs76/oikqYzvfQ=; b=VMNTjOhTR5oUtP0+X71EQ03aRw5nw4sOk+361dqwOayQK4cN//Vu4EJA64HW+lOdXt zLc3RFxF89ipWpOEjaCRDUrbdles/XcipiyExEJhvQ6pyxCHgZeGZibSqip6WYGHT82h TpJu/Qny4Yj+IOGveiajdIWPs+DL1Zi+BR2nhnHnFnoDIJjxmeN7DOBVM34IlZnYyfll lpJ8wN3dmxYASffE646J35CY5XWpvrdyvd2ONLY5pET5HtuVNQVpC7RvhDOsbq2bGOmN ffasVX0NMvSR40NPPM+eq/3Cu+VxQ+YH5MDzMh1KOKjylWiMiTChkiKj/zZwq9dXxVA+ n3eQ== X-Gm-Message-State: AMke39mN4radDDET4PLdxHe7zoX8uxXvxxhghERODy8vezJGzyqeDIHD5dDjHlijckSlCTd60YM5fBfcR46lrfNW X-Received: by 10.107.13.130 with SMTP id 124mr14018206ion.83.1488213570321; Mon, 27 Feb 2017 08:39:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Mon, 27 Feb 2017 08:39:29 -0800 (PST) In-Reply-To: References: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org> <20170227154401.GG16034@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 27 Feb 2017 16:39:29 +0000 Message-ID: To: Laszlo Ersek Cc: Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 16:39:31 -0000 Content-Type: text/plain; charset=UTF-8 On 27 February 2017 at 16:25, Laszlo Ersek wrote: > On 02/27/17 17:18, Ard Biesheuvel wrote: >> On 27 February 2017 at 15:44, Leif Lindholm wrote: >>> On Fri, Feb 24, 2017 at 06:40:25PM +0000, Ard Biesheuvel wrote: >>>> This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with >>>> any remaining references to it in various platform .DSC files. It is >>>> no longer used now that we removed the virtual uncached pages protocol >>>> and the associated DebugUncachedMemoryAllocationLib library instance. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Ard Biesheuvel >>> >>> Reviewed-by: Leif Lindholm >>> >> >> Thank you both >> >> I missed this one >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> index cc09d38910a2..d40ea69b072d 100644 >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> @@ -360,11 +360,6 @@ [PcdsFixedAtBuild.common] >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderCode|20 >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderData|0 >> >> - # >> - # ARM Pcds >> - # >> - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000000000000 >> - >> !if $(SECURE_BOOT_ENABLE) == TRUE >> # override the default values from SecurityPkg to ensure images >> from all sources are verified in secure boot >> gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x04 >> >> so I will fold that in, if there are no objections. > > sure, go ahead > Pushed, thanks.