Re: [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 11 March 2017 at 10:26, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
>> >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I
>> >> think the above check should be reworked to look for the FADT
>> >> (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE) with code lifted
>> >> from these helper functions. No driver outside of
>> >> QemuFwCfgAcpiPlatformDxe will install the FADT. And, the FADT will
>> >> always be part of QEMU's ACPI payload, if it generates one.
>> >
>> > OK, that would get things working again, I suppose. But do we want
>> > neutered ACPI tables to be exposed at all, even if there is a DT in
>> > that case to boot from?
>>
>> I think the neutered ACPI tables (on -no-acpi) should be fine. The
>> upstream Linux guest will prefer DT if it is present;
>
> Yes, but we've already determined that this situation is suboptimal,
> which was what triggered this changeset to begin with.
>

Indeed. Having an ACPI entry point config table installed, but not
having the essential tables that allow you to boot is a situation that
we should try very hard to avoid IMO