From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CB45F22280C27 for ; Wed, 27 Dec 2017 05:00:58 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id x28so25123072ita.0 for ; Wed, 27 Dec 2017 05:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=O68nmePKrCafRqVAbU6eQoF0PezWD/6bcSOdvnKvBx4=; b=jf9DTvptjzFsqSOYNitlOv2t+lkSWaBKB2cpXk0j5Or+G73PPvccd9DPNI3KNnkY4G A1tyOb4RR1OjlyJve6PP7xA+b/aeW/EZWabXFBhfPgC7Fy9EUly6LmPLN0cO7ZtdEHmb 9NU05Q4WicZjTHfJJpAJNsUZ0TJbAyHj1ACQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=O68nmePKrCafRqVAbU6eQoF0PezWD/6bcSOdvnKvBx4=; b=WHlq43l6yMaxmqTi8mx3Fk28iA84s/fk0QGpOyQ7/cz4NtIY5CqTvG1qgqtWER+63g BpYd9eiJfo/OZclu049F7H5k0bEoH+u5CMlL0DKkVshK2XThXUzDQ/wahqU6uuqszVwi vfAxJ2FUBfb0w5oBnw5skNmhc1HZJ1HehsY5Vw+z+Z0U1k6u9FBBa2CQ8ZLlRuPwDeXE ULSOgUQfsaR9keWHIetbOpkQm26BqDdLB2Pb5Yp8EvVoN0ckVqCTOLyRmGUqJDa9kJZ6 KbL09OmbXr0L5DJPL5HrOogPStv+N1Mco8Ae+uzK4GM+lcDwq1tVt7gTv0ahqTDf/IT1 a5LA== X-Gm-Message-State: AKGB3mKb94Fq8+c31nALcMABSXCFRRW4GuRanTSIvXN7cU4HfSQMGtEU 0G+cQn/I1AzpHDuIPJclMWrMG4vvo18ox/61a62Rzg== X-Google-Smtp-Source: ACJfBovRmGEQRxNVHZJQ/3Hj0TUn5AnCKWEVvQFd8dTNKpYlQspv8FN1Zc8LcBMXn7hrQ2a7bpAQtR43ZJZzEVC60dY= X-Received: by 10.36.55.138 with SMTP id r132mr36610962itr.34.1514379953415; Wed, 27 Dec 2017 05:05:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Wed, 27 Dec 2017 05:05:52 -0800 (PST) In-Reply-To: References: <1513882109-14295-1-git-send-email-vabhav.sharma@nxp.com> From: Ard Biesheuvel Date: Wed, 27 Dec 2017 13:05:52 +0000 Message-ID: To: Vabhav Sharma Cc: Leif Lindholm , "Kinney, Michael D" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host Bridge Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 13:00:59 -0000 Content-Type: text/plain; charset="UTF-8" On 27 December 2017 at 13:02, Vabhav Sharma wrote: > > >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>Sent: Friday, December 22, 2017 9:04 PM >>To: Vabhav Sharma >>Cc: Leif Lindholm ; Kinney, Michael D >>; edk2-devel@lists.01.org; Udit Kumar >>; Varun Sethi >>Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host >>Bridge Driver >> >>On 21 December 2017 at 18:48, Vabhav wrote: >>> Following patches will add support of NXP PCI Host Bridge Driver in edk2- >>platforms directory 'edk2-platforms/Platform/NXP' >>> >> >>Why do you need a new PciHostBridgeDxe driver? Can't you use the one in >>MdeModulePkg instead? > Using PciHostbridge dxe driver with changes for multiple(three) host bridge instances with 1:1 mapping for HostBridge:Root bridge(Hb:Rb), I will evaluate MdeModulePkg for > Multiple host bridge support You will need to re-implement PciSegmentLib for that. Please find an example here: https://git.linaro.org/leg/noupstream/edk2-platforms.git/tree/Silicon/Socionext/SynQuacer/Library/SynQuacerPciSegmentLib?h=developer-box >> >>> Updated Directory structure for added folders in 'edk2- >>platforms/Platform/NXP' will be: >>> >>> Platform/NXP/Drivers/PciHostBridgeDxe/ >>> |-- PciHostBridgeDxe.c >>> |-- PciHostBridgeDxe.inf >>> `-- PciRootBridgeIo.c >>> >>> Platform/NXP/Library/PciHostBridgeLib/ >>> |-- PciCntrl.c >>> |-- PciHostBridgeLib.inf >>> `-- PciRbLib.c >>> >> >>Please put these in Silicon/NXP, not Platform/NXP > Reference is taken from ARM/Hisilicon directory structure , We plan to put only chassis specific code in Silicon/NXP and Drivers, Library in Platform/NXP. > Please suggest if there is any specific reason for putting them in Silicon/NXP? Yes. Platform/ contains platform specific pieces, e.g., board level driver, device tree images, .DSC files etc. Libraries and drivers that can be shared between different platforms using the same SoC belong in Silicon/NXP. >> >>> In Platform/NXP/Library >>> PciHostBridgeLib librady is added >>> >>> In Platform/NXP/Drivers: >>> PciHostBridgeDxe driver is added >>> >>> Please review and look forward for your support in upstreaming the patches in >>edk2-platforms. >>> >>> Vabhav (3): >>> Platform/NXP : Add PCI Host Bridge Libary >>> Platform/NXP : Add PCI Host Bridge Driver >>> Compilation:Modify dsc,fdf files >>> >>> .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c | 967 ++++++++++++++++ >>> .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 61 + >>> .../NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c | 1193 >>++++++++++++++++++++ >>> Platform/NXP/Include/PciCntrlLib.h | 323 ++++++ >>> Platform/NXP/Include/PciHostBridge.h | 466 ++++++++ >>> Platform/NXP/Include/PciLib.h | 414 +++++++ >>> Platform/NXP/Include/PciRootBridge.h | 674 +++++++++++ >>> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 31 + >>> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 6 + >>> Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c | 628 +++++++++++ >>> .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 49 + >>> Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c | 331 ++++++ >>> Silicon/NXP/Chassis/Chassis.c | 11 + >>> Silicon/NXP/Chassis/Chassis2/SerDes.h | 11 + >>> Silicon/NXP/LS1043A/LS1043A.dsc | 1 + >>> 15 files changed, 5166 insertions(+) >>> create mode 100644 >>> Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c >>> create mode 100644 >>> Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf >>> create mode 100644 >>> Platform/NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c >>> create mode 100644 Platform/NXP/Include/PciCntrlLib.h >>> create mode 100644 Platform/NXP/Include/PciHostBridge.h >>> create mode 100644 Platform/NXP/Include/PciLib.h create mode 100644 >>> Platform/NXP/Include/PciRootBridge.h >>> create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c >>> create mode 100644 >>> Platform/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf >>> create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c >>> >>> -- >>> 1.9.1 >>>