From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1F4A211B7F9E for ; Wed, 16 Jan 2019 09:44:52 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id t24so5600261ioi.0 for ; Wed, 16 Jan 2019 09:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9dqhg/qrhOnp62EVRRsYHm5dTkA/2lRKYjOEdCRH/7Y=; b=jxFPKtONxDa1DjF+OQXfEv5zgJBWYS+lzkfp8NxV5MTk7j2K2BUDTvq70Zro7sCnJy +jykfTvC04jLtUCWxRg2aKJdkRp7yV4jqvax5+IH0XgVAqTLtj1V4cc1ZMfQO7KdtP+E NZjjoornNag0vgEBlbk35Ic2vJUbC1jPha21Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9dqhg/qrhOnp62EVRRsYHm5dTkA/2lRKYjOEdCRH/7Y=; b=aDvB+l9g91AjmNDXOQI0Fp//tYy5ov7mQnHYAvPuVm0/AN4ywuSqx1SYB+Fmn2nCPQ v/cK3DNPfUbVe2hcHrnkYdM8cUvidsfF4lAxyqZMhR3ECYJa5Wwvh/lj7ZdwkU+XGG/J i5Wb5R2NRHFobrlkyyWrJM2cwe2YEn/f/DB6/jpP2Fh3/yklUcT0HIPVwcGrncwFpt6h Ayfxxoouzc/27xL4tdqqr9ZfAbbLqTmFJyGAWsRffMu1djZZonNzJa/+s/EbovtsN5Up JDSSiPDiHKsoKY1XY/poCHzTcKydO87uqi3/ztqxTin6Kteq7e7y1jWuuFHIwmZ63C76 lCaw== X-Gm-Message-State: AJcUukdfN+fLdz0Admo4aS8n5a+GYpdfIhWhgGWbuhTicrsJeuoZngRc hOt+kwriXXi3DWSZuam8FtQ954J9SpO8qjlrwBp2MQ== X-Google-Smtp-Source: ALg8bN6ZuqqiMtEwixwhpE2WSrZijfer+5imMkMYEFr4pJrW7viRX2OIcU8x6Vr7y96OiWIQA1TFRYpU3iYfD7BTYsY= X-Received: by 2002:a5e:c206:: with SMTP id v6mr5847920iop.60.1547660691495; Wed, 16 Jan 2019 09:44:51 -0800 (PST) MIME-Version: 1.0 References: <20190114132758.24054-1-ard.biesheuvel@linaro.org> <20190114132758.24054-5-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B3306@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B3306@SHSMSX152.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 16 Jan 2019 18:44:40 +0100 Message-ID: To: "Gao, Liming" , "Qian, Yi" Cc: "edk2-devel@lists.01.org" , "Sun, Zailiang" , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" , Jagadeesh Ujja , Achin Gupta , Thomas Panakamattam Abraham , Sami Mujawar , "Zeng, Star" Subject: Re: [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 17:44:52 -0000 Content-Type: text/plain; charset="UTF-8" (add Yi as well) On Wed, 16 Jan 2019 at 16:14, Gao, Liming wrote: > > Zailiang: > Could you help review this change? > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Monday, January 14, 2019 9:28 PM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Kinney, > > Michael D ; Gao, Liming ; Wang, Jian J ; Wu, Hao A > > ; Jagadeesh Ujja ; Achin Gupta ; Thomas Panakamattam > > Abraham ; Sami Mujawar ; Zeng, Star > > Subject: [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution > > > > The SMM based FTW and variable drivers are going to depend on > > MmServicesTableLib after a subsequent patch, so add a resolution > > for it to various Vlv2TbltDevicePkg .dsc files. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > 3 files changed, 3 insertions(+) > > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > index d43611550285..eb7c205a10a6 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > @@ -406,6 +406,7 @@ [LibraryClasses.X64.DXE_CORE] > > !endif > > > > [LibraryClasses.X64.DXE_SMM_DRIVER] > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > index a33816c4d18b..b2f0d73f6d05 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > @@ -406,6 +406,7 @@ [LibraryClasses.IA32.DXE_CORE] > > !endif > > > > [LibraryClasses.IA32.DXE_SMM_DRIVER] > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > index 1da1442c64c6..aa62c07f177b 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > @@ -408,6 +408,7 @@ [LibraryClasses.X64.DXE_CORE] > > !endif > > > > [LibraryClasses.X64.DXE_SMM_DRIVER] > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf > > -- > > 2.20.1 >