From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6204.1585651179896120736 for ; Tue, 31 Mar 2020 03:39:40 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6662C101E for ; Tue, 31 Mar 2020 03:39:39 -0700 (PDT) Received: from mail-wr1-f48.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3AB503F802 for ; Tue, 31 Mar 2020 03:39:39 -0700 (PDT) Received: by mail-wr1-f48.google.com with SMTP id j17so25178032wru.13 for ; Tue, 31 Mar 2020 03:39:39 -0700 (PDT) X-Gm-Message-State: ANhLgQ2vyc4thCl/NQLiylRCySH0/34HL9joAJgtSZsQU9aRiq4k6F25 YZ5KhZ6UKFf5DU6k7gyOwbJH3VVnQdQWU0qWf1H7oQ== X-Google-Smtp-Source: ADFU+vuUFDxhEMSkSZoU5TiurKgaH7QWmcfP+yv/WhX+EQS8mh6Q3LgDd9JCNnKPZgFiRXYbgOBScIul7HdDkiNHZHY= X-Received: by 2002:a5d:604a:: with SMTP id j10mr19358850wrt.126.1585651174032; Tue, 31 Mar 2020 03:39:34 -0700 (PDT) MIME-Version: 1.0 References: <20200325105252.13905-1-aditya.angadi@arm.com> <20200325105252.13905-7-aditya.angadi@arm.com> In-Reply-To: <20200325105252.13905-7-aditya.angadi@arm.com> From: "Ard Biesheuvel" Date: Tue, 31 Mar 2020 12:39:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms][PATCH v3 6/9] Platform/ARM/Sgi: add initial support To: Aditya Angadi Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > Add information in the SGI platform descriptor HOB to pick the correct > ACPI table to install for RD-Daniel Config-M > This description does not make sense. You are adding a completely new SGI flavour called 'Daniel' in this patch, right? Please make that a separate patch. > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Aditya Angadi > --- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4 +++ > Platform/ARM/SgiPkg/RdDaniel.dsc | 37 ++++++++++++++++++++ > 4 files changed, 47 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > index 387397d74598..7e0de765f753 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -46,6 +46,11 @@ STATIC SGI_PLATFORM_ACPI_TABLE_GUID_LOOKUP AcpiTableGuidLookup[] = { > RD_E1_EDGE_CONF_ID, > MULTI_CHIP_MODE_DISABLED, > &gRdE1EdgeAcpiTablesFileGuid), > + ACPI_GUID_LOOKUP ( > + RD_DANIEL_PART_NUM, > + RD_DANIEL_CFGM_CONF_ID, > + MULTI_CHIP_MODE_DISABLED, > + &gRdDanielCfgMAcpiTablesFileGuid), > }; > > VOID > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > index 741dcc75ed6a..82569820b78c 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > @@ -34,6 +34,7 @@ [Guids] > gRdN1EdgeAcpiTablesFileGuid > gRdN1EdgeX2AcpiTablesFileGuid > gRdE1EdgeAcpiTablesFileGuid > + gRdDanielCfgMAcpiTablesFileGuid > > [FeaturePcd] > gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index d87fb2b5409f..b6a427b8b657 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -70,6 +70,10 @@ > #define RD_N1_EDGE_CONF_ID 0x1 > #define RD_E1_EDGE_CONF_ID 0x2 > > +//RDDANIEL Platform Identification values > +#define RD_DANIEL_PART_NUM 0x78A > +#define RD_DANIEL_CFGM_CONF_ID 0x1 > + > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > #define SGI_PART_NUM_MASK 0xFFF > diff --git a/Platform/ARM/SgiPkg/RdDaniel.dsc b/Platform/ARM/SgiPkg/RdDaniel.dsc > new file mode 100644 > index 000000000000..83e7ccd0bc05 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/RdDaniel.dsc > @@ -0,0 +1,37 @@ > +# > +# Copyright (c) 2020, ARM Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +################################################################################ > +# > +# Defines Section - statements that will be processed to create a Makefile. > +# > +################################################################################ > +[Defines] > + PLATFORM_NAME = ArmSgi > + PLATFORM_GUID = d301ac4e-0828-4cef-b754-34ca9b6781b5 > + PLATFORM_VERSION = 0.1 > + DSC_SPECIFICATION = 0x0001001B > + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > + SUPPORTED_ARCHITECTURES = AARCH64|ARM > + BUILD_TARGETS = NOOPT|DEBUG|RELEASE > + SKUID_IDENTIFIER = DEFAULT > + FLASH_DEFINITION = Platform/ARM/SgiPkg/SgiPlatform.fdf > + BUILD_NUMBER = 1 > + > +# include common definitions from SgiPlatform.dsc > +!include Platform/ARM/SgiPkg/SgiPlatform.dsc > + > +################################################################################ > +# > +# Pcd Section - list of all EDK II PCD Entries defined by this Platform > +# > +################################################################################ > + > +[PcdsFixedAtBuild.common] > + # GIC Base Addresses > + gArmTokenSpaceGuid.PcdGicDistributorBase|0x30000000 > + gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x30140000 > + gArmSgiTokenSpaceGuid.PcdGicSize|0x200000 > -- > 2.17.1 >