From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01500211AE8D0 for ; Mon, 11 Jun 2018 05:01:22 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id y127-v6so11105398itd.1 for ; Mon, 11 Jun 2018 05:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1kxJrgOKemNqOk25EsUZzk/PI39Sy+nAI3D7Oo5mmEs=; b=WMEx35Rn2aEK2DEpC8LBod9ury6mLSs/rS9WU7aGFdtoBEQ1Nl9tDxJXWldzk+03IP /epULMsoxCMhxMfU3IFYwDTabN0sYBcXAGinVk4zzzNoxlMachScmzmWUO1wWRVkq9nx J8hNme4exIsdK/JpDMEmyO+6S5l+gFF7+xnPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1kxJrgOKemNqOk25EsUZzk/PI39Sy+nAI3D7Oo5mmEs=; b=Gs7TFlkZBTedF9Ehfy3V8IZel15PeDhdheS6r9cE5tOdMx62q/snQmXo0xISOOrXQY PAWpQ7VydJ76HdWaWDHxXyBCl9M78jXwWYm+mu0S9LXh/IeQtDZxknWovL8Et9CqATL/ +9MPyeDjhUuGdwpsicxIp4kDZEl6ydsyFOK6FClLzt5u+Nsie6qYnAMC7lH6l96P3NN4 pJTIy7H8FXoniQN0HMiP3e0bRGRPpdQYmjfDDTdG6UiFyPBovpYfE3avFs1BnHZEOhwH CnNwb/Cnxcd0MzXM6EU6jynM6kfMNeXnS0cHlX1cnoRptDGUxhYpow52VoJaVRRakJHu qWVQ== X-Gm-Message-State: APt69E1OXmuckZ8q5LbA6a9QD+ojUkJ6ZAPzIBLje7IaFycZtj1dV1Me R1+XfWFheArNGsu5y3uysdEmhh+Mo32N0kG/QgnV9g== X-Google-Smtp-Source: ADUXVKK7XKdaOMMM/Zo61Jw/Fz6dJLbS30vj+O5uC5+bH8bjkEMe5wvfxkkk2EBLroD5BR2/T5G+p3poOOwPXaKK1dc= X-Received: by 2002:a24:e105:: with SMTP id n5-v6mr10091678ith.68.1528718481597; Mon, 11 Jun 2018 05:01:21 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 05:01:21 -0700 (PDT) In-Reply-To: References: <1528472063-1660-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Mon, 11 Jun 2018 14:01:21 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Hua Jing , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms PATCH 00/25] Armada herdware description rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 12:01:23 -0000 Content-Type: text/plain; charset="UTF-8" On 11 June 2018 at 13:49, Marcin Wojtas wrote: > Hi Ard, > > 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel : >> Marcin, >> >> I am a bit reluctant to review another huge set of Armada patches >> while we are still waiting for MacchiatoBin support to land. The only >> hardware i have access to is MacchiatoBin, and it has been well over a >> year now that MacchiatoBin support has been between 'under >> construction' and 'about to land any day now'. >> >> The patches in this series actually carry traces of McBin support, >> which suggests to me that they were taken from an internal tree that >> does support MacchiatoBin, but it has been removed. What is that >> about? > > MacchiatoBin addition is on top of those patches in the branch I > prepared solely for upstream. Anyway, I understand your point and > let's skip this big patchset for now. I will submit support for other > boards, once it's accepted, let's return to this one. > Patch 5/25: """ From: jinghua This patch enables compilation of MvBoardDescDxe driver for Armada70x0-DB, Armada80x0-DB and Armada80x0McBin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: jinghua Reviewed-by: Kostya Porotchkin """ So this patch clearly contained MacchiatoBin support at some point, but you removed it before upstreaming the patch. That really makes me sad. BTW can you please drop the @marvell.com Reviewed-by tags, and add your own Signed-off-by to patches that you did not author yourself?