From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 00A1A20945B80 for ; Tue, 19 Sep 2017 09:39:55 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id g32so498381ioj.2 for ; Tue, 19 Sep 2017 09:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KtCD0bRdurxlTjKvPqno1s6fjvG9pHEoLSwBY/rZwtU=; b=d6F//Z6m5CfPAnBzIS8U+lLczG31G7XAI6sBv+H0YHl+ezX3wXTaYncKvGbvRfXySx nlalyZnye0CQQd3Rmq3LcjYdA2Fk3TpwS+ZG5Go93hJMQkm6OkwZHHF/35kbyu7NUR1L 49VOArrSs9S5ZBEr2Se0vbs13MbELeGngm6BQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KtCD0bRdurxlTjKvPqno1s6fjvG9pHEoLSwBY/rZwtU=; b=gtng2e8lkXLfDFcOId6/7YG/ImBubr/ZUcciLIrZI3J2oPJzSHnpcoIiIn56Q7A+1l hXSQasJ5YQM0S0XwkKPrYx3HcjC8556h5nCNc7r9OPWeixkjyPZxMt7EV0b1dVqUDDp7 0UZeINC5V314C0a012W2ulV8AxKsZSqmNWmqFUZN9e5hKnbHpWLzgnHUXyMU8xc6pzO/ luKFXHhJvPNJPf7yMy0VO2aA5JhWBIZGFOawBVPQVx+d+Sx/nJVS2RZ7R/bFq6vh35Vq vaFeAmaM7utWyJ8r5dnSIOLNz5sf/Xlikv/kWmi11ckSHVjn72vGmbXAr28ZMsQGWbTq oXfw== X-Gm-Message-State: AHPjjUgm/ViLWXtm+svFQxYQxXQC+SumP5/XKYEhZPpF4xwFBc3gvO3V DYGXhRAJT9qrrbpGuTPI6ZE33847Z7PyJkve7pvFyg== X-Google-Smtp-Source: AOwi7QCnr1SvNgQz+LawtRpWPSq+wfMirIADMwsayzI/maTuORZ99bsFymMGBtgKB5tEZSeGZktSS58TT2fS/WrzUeI= X-Received: by 10.107.15.141 with SMTP id 13mr2533395iop.141.1505839379219; Tue, 19 Sep 2017 09:42:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.152.18 with HTTP; Tue, 19 Sep 2017 09:42:58 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E153203@SHSMSX152.ccr.corp.intel.com> References: <20170915231356.23936-1-ard.biesheuvel@linaro.org> <20170916073343.xamfucw5i52wyczc@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E153203@SHSMSX152.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 19 Sep 2017 09:42:58 -0700 Message-ID: To: "Gao, Liming" Cc: Leif Lindholm , "edk2-devel@lists.01.org" , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/tools_def AARCH64: enable frame pointers for RELEASE builds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 16:39:55 -0000 Content-Type: text/plain; charset="UTF-8" On 17 September 2017 at 22:06, Gao, Liming wrote: > Reviewed-by: Liming Gao > [...] >>> >>> So remove -fomit-frame-pointer altogether this time. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >> >>Looks sensible. >>Reviewed-by: Leif Lindholm >> Pushed as 424a5ec33b3d5a842bff3f4695d0bd709c91a163 Thanks.