Re: [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 4 December 2017 at 17:17, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Dec 04, 2017 at 05:15:35PM +0000, Ard Biesheuvel wrote:
>> On 4 December 2017 at 17:13, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> > D02, D03 and D05 all have nice conditional clauses to only include
>> > the non-standard tftp shell command ifdef(INCLUDE_TFTP_COMMAND).
>> >
>> > Unfortunately, they all explicitly set DEFINE INCLUDE_TFTP_COMMAND=1 in
>> > their platform description files, meaning there is no way to exclude the
>> > command without an editor.
>> >
>> > So remove the DEFINE and let people specify on the command line whether
>> > to include it, as originally intended.
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>> Assuming that not defining the macro is the same as defining it to 0
>
> Well, the test was ifdef, which is what made the below a bug rather
> than an undesirable default :)
>

Ah right. I missed that. So yes, please remove that.