From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::233; helo=mail-io0-x233.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 93D91203564AF for ; Wed, 29 Nov 2017 01:54:47 -0800 (PST) Received: by mail-io0-x233.google.com with SMTP id g1so3075610ioc.8 for ; Wed, 29 Nov 2017 01:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5zKQCjjb2fxh8kgrHe9VIbOmakKUkq38BK2d2COAjc0=; b=MK9c+KeEgsbcsJLbau/b5br4cfOFwOX/MjcTUOBe4fhzlYIqc9zrB8/Nh3IKysNPEd vGSq3oBPajTWTORtJAtV1wzzcUbnzkyNyMKTofTChCltLB85dbcF0f4UEDhE9U8MV/ta vqa2TGnEiKVJ0txLw/J1ZspoSvTNvBuC4BHUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5zKQCjjb2fxh8kgrHe9VIbOmakKUkq38BK2d2COAjc0=; b=jYbOgTDpFJI3iy+lnX1w2GHK5grIJxARhaxg1uXREOKC4zD331PlICZWJLBd5J3e72 SY+asjI6lnBT0qtlhzqwrPp4pH7sW23BsbJBNP58yD9FHutDu2ZNn19QFkvwezVp5FlZ TUtTIRbQbp64eMKj9DtUZkKa5txrqqDRf4mZdzuVNQb/tOeZhR0A8pcvdiN7nnhLF5pI WRhQyw9cJrf7m++SkEclOv5thi3hUEqx95aQOd5zRahirelA4T02lmW5FYqLwQMMmZjD fhxt7Pc7DF+bTZOOwCC43TpCNrPGJvZMig4U8fu3oXNvngfJ6U74P00Sx2g0hPXRkBdU GzVQ== X-Gm-Message-State: AJaThX7om4pC553WPWaD2XsZExioaNELCTTgvPM8GVSwzp6O7am8dsbI KkUdhbDvcJTzLLD3ApDbAFIbxh0DJydjpFaUbq3/lCBDROw= X-Google-Smtp-Source: AGs4zMYQ0rcWxrNlUwwKF0nxCkbpk1msuwGsHiTojclFpUCY8Q/GOh7wEo1wD6Kll1Rquhf1p+YuDfElse0kN2IPUeM= X-Received: by 10.107.2.137 with SMTP id 131mr2743379ioc.186.1511949550651; Wed, 29 Nov 2017 01:59:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 29 Nov 2017 01:59:10 -0800 (PST) In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BAD6B46@SHSMSX104.ccr.corp.intel.com> References: <20171129005952.208940-1-ruiyu.ni@intel.com> <20171129005952.208940-4-ruiyu.ni@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BAD6AA3@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5BAD6B46@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 29 Nov 2017 09:59:10 +0000 Message-ID: To: "Ni, Ruiyu" Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 09:54:47 -0000 Content-Type: text/plain; charset="UTF-8" On 29 November 2017 at 09:57, Ni, Ruiyu wrote: > I didn't see Laszlo provided any comments for this patch. https://lists.01.org/pipermail/edk2-devel/2017-November/018124.html > Did you mean the below comments from him for OvmfPkg's change? > > (1) Please add the following to the commit message: > "The TFTP command was converted from a NULL class library instance to a dynamic shell command in commit 0961002352e9. This patch complements commit f9bc2f876326, which only removed the old library, but didn't add the new dynamic command." > > Thanks/Ray > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Wednesday, November 29, 2017 5:45 PM >> To: Ni, Ruiyu >> Cc: edk2-devel@lists.01.org; Laszlo Ersek >> Subject: Re: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp >> library removal >> >> On 29 November 2017 at 09:36, Ni, Ruiyu wrote: >> > Ard, >> > Would you mind to give a r-b for this patch? >> > >> >> Hi Ray, >> >> Could you please incorporate the feedback you received from Laszlo first? >> Thanks. >> >> >> > >> >> -----Original Message----- >> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >> >> Of Ruiyu Ni >> >> Sent: Wednesday, November 29, 2017 9:00 AM >> >> To: edk2-devel@lists.01.org >> >> Cc: Laszlo Ersek ; Ard Biesheuvel >> >> >> >> Subject: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to >> >> Tftp library removal >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ruiyu Ni >> >> Cc: Laszlo Ersek >> >> Cc: Ard Biesheuvel >> >> Cc: Julien Grall >> >> --- >> >> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++---- >> >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- >> >> ArmVirtPkg/ArmVirtXen.fdf | 3 ++- >> >> 3 files changed, 11 insertions(+), 6 deletions(-) >> >> >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> >> index 5d7edff104..9874637a3d 100644 >> >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> >> @@ -1,7 +1,7 @@ >> >> # >> >> # Copyright (c) 2011-2015, ARM Limited. All rights reserved. >> >> # Copyright (c) 2014, Linaro Limited. All rights reserved. >> >> -# Copyright (c) 2015, Intel Corporation. All rights reserved. >> >> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved. >> >> # >> >> # This program and the accompanying materials # are licensed and >> >> made available under the terms and conditions of the BSD License @@ >> >> -55,6 +55,8 @@ [LibraryClasses.common] >> >> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf >> >> >> >> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiSer >> >> UefiHiiServicesLib|vice >> >> sLib.inf >> >> SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf >> >> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> >> + >> >> + FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.in >> >> + f >> >> >> >> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf >> >> >> >> >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTree >> >> OrderedCollectionLib|L >> >> ib/BaseOrderedCollectionRedBlackTreeLib.inf >> >> @@ -217,8 +219,6 @@ [LibraryClasses.common.UEFI_APPLICATION] >> >> >> >> >> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma >> >> nceLib.inf >> >> >> >> >> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo >> >> ryAllocationLib.inf >> >> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf >> >> - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> >> - >> >> FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf >> >> >> >> [LibraryClasses.common.UEFI_DRIVER] >> >> >> >> >> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCusto >> >> mDecompressLib/BaseUefiTianoCustomDecompressLib.inf >> >> @@ -383,6 +383,10 @@ [Components.common] >> >> # >> >> # UEFI application (Shell Embedded Boot Loader) >> >> # >> >> + >> >> >> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. >> >> inf { >> >> + >> >> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> >> + } >> >> ShellPkg/Application/Shell/Shell.inf { >> >> >> >> >> >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma >> >> ndLib.inf >> >> @@ -393,7 +397,6 @@ [Components.common] >> >> >> >> >> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com >> >> mandsLib.inf >> >> >> >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1C >> >> NULL|om >> >> mandsLib.inf >> >> >> >> >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 >> >> CommandsLib.inf >> >> - >> >> >> NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib >> >> .inf >> >> >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandlePars >> >> HandleParsingLib|ingL >> >> ib.inf >> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> >> >> >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg >> >> CommandLib.inf >> >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> >> b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> >> index 744006d13c..89f95b2d99 100644 >> >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> >> @@ -1,7 +1,7 @@ >> >> # >> >> # Copyright (c) 2011-2015, ARM Limited. All rights reserved. >> >> # Copyright (c) 2014-2016, Linaro Limited. All rights reserved. >> >> -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. >> >> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved. >> >> # >> >> # This program and the accompanying materials # are licensed and >> >> made available under the terms and conditions of the BSD License @@ >> >> -103,6 >> >> +103,7 @@ [FV.FvMain] >> >> # UEFI application (Shell Embedded Boot Loader) >> >> # >> >> INF ShellPkg/Application/Shell/Shell.inf >> >> + INF >> >> >> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. >> >> inf >> >> >> >> # >> >> # Bds >> >> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf >> >> index >> >> 70e76df228..6586ce6be5 100644 >> >> --- a/ArmVirtPkg/ArmVirtXen.fdf >> >> +++ b/ArmVirtPkg/ArmVirtXen.fdf >> >> @@ -1,7 +1,7 @@ >> >> # >> >> # Copyright (c) 2011-2015, ARM Limited. All rights reserved. >> >> # Copyright (c) 2014, Linaro Limited. All rights reserved. >> >> -# Copyright (c) 2015 - 2016, Intel Corporation. All rights >> >> reserved.
>> >> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights >> >> +reserved.
>> >> # >> >> # This program and the accompanying materials # are licensed and >> >> made available under the terms and conditions of the BSD License @@ >> >> -169,6 >> >> +169,7 @@ [FV.FvMain] >> >> # UEFI application (Shell Embedded Boot Loader) >> >> # >> >> INF ShellPkg/Application/Shell/Shell.inf >> >> + INF >> >> >> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. >> >> inf >> >> >> >> # >> >> # Bds >> >> -- >> >> 2.15.0.gvfs.1.preview.4 >> >> >> >> _______________________________________________ >> >> edk2-devel mailing list >> >> edk2-devel@lists.01.org >> >> https://lists.01.org/mailman/listinfo/edk2-devel