From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com;
 envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org 
Received: from mail-it0-x244.google.com (mail-it0-x244.google.com
 [IPv6:2607:f8b0:4001:c0b::244])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 11B8521102DAD
 for <edk2-devel@lists.01.org>; Fri, 15 Jun 2018 03:58:14 -0700 (PDT)
Received: by mail-it0-x244.google.com with SMTP id 16-v6so2090916itl.5
 for <edk2-devel@lists.01.org>; Fri, 15 Jun 2018 03:58:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=7k+LDCK9Y59V5pth/iZ6PQEFqGBEQ2kY+AiKSccmB9E=;
 b=BRIK9gZSmY46bN4tI6KWOdJDh61RZQZ88DzBecJMv0LrIOy5pEH2ulzmDR2jdD90Iq
 XlHZqjvyZqBZ2HotFfHxfIUDG/Q2NiCDChtAXThGrMtUgQW1uC1KSNquhi0LZR97BjeU
 T/a7TD6YvXShtLUgL2sUJ1+FGMTZFVM4gGIps=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=7k+LDCK9Y59V5pth/iZ6PQEFqGBEQ2kY+AiKSccmB9E=;
 b=r4yO+03omgI+L3ErpTS1M0ZYheJBLWXQ3QeW/NHKG0cTLfOCiAortO4yo4N1HzMODZ
 pYws/din6CTIE/efd03HqmAi6rpL9WPy6io6nJxjNG8e9S46gvbeCVHVrJHu6Jmo1WiN
 mGydgV/vURUzaac6/apT+9gKj7VLFbYnTIWC1ACoJcQVLnPkOku3AtHdHNIB+wUS30uJ
 UFVgcvmb4aOHLvHy0bXQqysy0xlZdE3yZA3+BvJvOX32JzcfAp6dSHv0oSQIWbzdc5y1
 o0yR86sfp9zwx1sd0yC7gVCAzbv38DVqrXRzTyz7apKl5zraCgZO3sZjK4r6Ogfz/yYV
 80xw==
X-Gm-Message-State: APt69E02ylXLVqHwrn6/F070iIKHMLmEgxUaauisTNQauLfIENCUuSue
 5DZIMUiJP3jtJNTr2yXqxsbMB6ITpj/n3EH0O0lzpg==
X-Google-Smtp-Source: ADUXVKIy3Ym6RYuquh2R7pPjv4KkTYumo4C5GZGNlEB3rNrQnevu7JLPIw9I43kgAsuxVQcsT8KxRKAUXKFCXs96rFw=
X-Received: by 2002:a02:4187:: with SMTP id n7-v6mr348832jad.86.1529060293929; 
 Fri, 15 Jun 2018 03:58:13 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Fri, 15 Jun 2018 03:58:13
 -0700 (PDT)
In-Reply-To: <1528834449-12726-3-git-send-email-udit.kumar@nxp.com>
References: <1528834449-12726-1-git-send-email-udit.kumar@nxp.com>
 <1528834449-12726-3-git-send-email-udit.kumar@nxp.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Fri, 15 Jun 2018 12:58:13 +0200
Message-ID: <CAKv+Gu-=P-0whzuERv1N4oW9JTRnYvQjHjDUT=4mbZMgkuhD4Q@mail.gmail.com>
To: Udit Kumar <udit.kumar@nxp.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>, 
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 10:58:15 -0000
Content-Type: text/plain; charset="UTF-8"

On 12 June 2018 at 22:14, Udit Kumar <udit.kumar@nxp.com> wrote:
> This patch gets PL011 baud rate clock from
> pl011 uart clock lib instead of Pcd.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Udit Kumar <udit.kumar@nxp.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 112c6c22376267a79f4a4ac0c4263bf24a548d81

> ---
>  ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c   | 5 +++--
>  ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> index 6aa8063..212991d 100644
> --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> @@ -19,6 +19,7 @@
>
>  #include <Library/IoLib.h>
>  #include <Library/PcdLib.h>
> +#include <Library/PL011UartClockLib.h>
>  #include <Library/PL011UartLib.h>
>  #include <Library/SerialPortLib.h>
>
> @@ -48,7 +49,7 @@ SerialPortInitialize (
>
>    return PL011UartInitializePort (
>             (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
> -           FixedPcdGet32 (PL011UartClkInHz),
> +           PL011UartClockGetFreq(),
>             &BaudRate,
>             &ReceiveFifoDepth,
>             &Parity,
> @@ -156,7 +157,7 @@ SerialPortSetAttributes (
>  {
>    return PL011UartInitializePort (
>             (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
> -           FixedPcdGet32 (PL011UartClkInHz),
> +           PL011UartClockGetFreq(),
>             BaudRate,
>             ReceiveFifoDepth,
>             Parity,
> diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> index 3683e06..5ce5b2f 100644
> --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> @@ -26,6 +26,7 @@
>    PL011SerialPortLib.c
>
>  [LibraryClasses]
> +  PL011UartClockLib
>    PL011UartLib
>    PcdLib
>
> --
> 1.9.1
>