From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67D8C20D2C3B9 for ; Mon, 27 Mar 2017 10:45:31 -0700 (PDT) Received: by mail-it0-x232.google.com with SMTP id y18so83753318itc.0 for ; Mon, 27 Mar 2017 10:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6bs2UjYecOuXevHHEDiM18PZHHAnX7Zzm64TuhaggTI=; b=jFpd5H1YyPUnbCQs28wbNrzS3E+pKSUcvOa3Vm1p91JniPfoPeta4gtghp7OONuo/j GbDHxfVPyHWSBzLcK1fHzoWLeFJixRm0CGH/SW11JdlH5QgL15Ewd2+nP7r4OW2Pugza X/DTt00r6COjucybZDabV6ZOsgLwXlpAwAmeQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6bs2UjYecOuXevHHEDiM18PZHHAnX7Zzm64TuhaggTI=; b=lPRg8RYoVJKcLbnSJ+JmJi4UEW4e2lh+0ycezJdRxM+KNJnbgr5KGcjayujqhrR4JB Lsxkp+Wz6CCXf/uopV50hYYGkmM3GhOfjOoNy9Z4eIu8fvutuqwQEEYI8F9YW3aEb/45 NxtjMJimJ52ZAF27LL7B3UIaCzk68UVxCyFY2d+92n3xZ+XzOLVFxjj5VxqmdAuUbCz5 MmJwZDrEUysc+6Sgld+o3Chm0o8IC6mZXDZ17Q6q7xVwR8PNNS6BqOmCNu/u1nA/hOWQ W5gTBGB/p6NcZdHfofYgagHvYLBqa2MC0RHvl7dWJ1EzGFfGwcYA1PetUlKGACC75wkU /R8Q== X-Gm-Message-State: AFeK/H3lJyZVkr5sbOI62RPB+w4qbEny2gm28FV0tXZ84z0tfB025rWXcpSysyeGaZyW1FY+K9mKKssMeNGic9jT X-Received: by 10.107.141.134 with SMTP id p128mr20695154iod.83.1490636730681; Mon, 27 Mar 2017 10:45:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Mon, 27 Mar 2017 10:45:29 -0700 (PDT) In-Reply-To: <66e4cce5-1a24-2ea2-f701-39ff9dde0897@redhat.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-6-lersek@redhat.com> <20170318150041.GL16034@bivouac.eciton.net> <1bc7b29c-7a71-86cb-adce-5a14de129c63@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8377AB@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B84CA03@shsmsx102.ccr.corp.intel.com> <5b2c0152-85fe-db6b-e173-0e4b0891e0f2@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D702AE8@shsmsx102.ccr.corp.intel.com> <66e4cce5-1a24-2ea2-f701-39ff9dde0897@redhat.com> From: Ard Biesheuvel Date: Mon, 27 Mar 2017 18:45:29 +0100 Message-ID: To: Laszlo Ersek , "Kinney, Michael D" , "afish@apple.com" , Leif Lindholm Cc: "Gao, Liming" , "Zeng, Star" , "Tian, Feng" , edk2-devel-01 Subject: Re: [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 17:45:31 -0000 Content-Type: text/plain; charset=UTF-8 On 27 March 2017 at 18:31, Laszlo Ersek wrote: > On 03/27/17 09:00, Ard Biesheuvel wrote: >> On 27 March 2017 at 03:42, Gao, Liming wrote: >>> Laszlo: >>> On GUID header file, some header file are here, because they are added before BaseTools supports it. Now, we allow not to add header file if the header file only has GUID value definition. >> >> I have to agree with Laszlo here. The BaseTools support is incomplete, >> since it does not add a #define for the GUID to AutoGen.h. This makes >> it impossible to initialize static structures containing GUIDs, such >> as templates containing vendor device paths. >> >> For instance, the following >> >> typedef struct { >> EFI_GUID foo; >> } TYPE; >> >> TYPE mFoo { >> SOME_GUID >> }; >> >> is not possible without a Guid/xxx.h include file containing a #define >> for SOME_GUID. > > I wonder if we can commit this series before end of April. > > Or is that too soon? End of May perhaps? > > The mind boggles. > Reviewed-by: Ard Biesheuvel