From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=P4VnD0hE;
 spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194])
 by groups.io with SMTP; Fri, 17 May 2019 08:06:26 -0700
Received: by mail-it1-f194.google.com with SMTP id q132so12444316itc.5
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:06:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=hro7bnvGlWoRMuEKH+eRomu+LW70WAendxrvi32V69o=;
        b=P4VnD0hEHujfqN8tyTyzscxvxZ5wN6XBKaYXK1TYm/SW6mDUB5PvXTnXt3MRCTuqNn
         F82WknnKCR5ZZNAEZIfYeqMKouS5KLy1i8ANnHDjBky+TXO6/SNcREmQA9s0sVMxwC+p
         85WxfporkAa0g7ZBJxt+06nNSPmNnbH+cx4Ltcaxlxj970Cy9y4qKOCT73k/rmScqPHG
         e0w6lb5nw+DqQAsG3qbPxzRY7hjctEMllFefwF8SYIEIj5QjOy/UYNTSkIqbehWUWuTe
         /kNVj0ICRKKvy5LY8ZOwv3GEVTlrlXFp0rcZCl1EUOafU879i12rWbnNEEBli3YiX0F+
         otQw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=hro7bnvGlWoRMuEKH+eRomu+LW70WAendxrvi32V69o=;
        b=b+3NRezGRgPSI/xK9ZsEMl4nHPmqUQfOLS7DD0RLeTPphz/x96YHBVane5fn/WhJrz
         m4udlr4wkVJqE4OYbrwHQC2pT0deMhzooS+W7yFezJYuoUL+O/FR2KY5XrWwg3nO7upn
         oHUq4Msmq3INF/oTwJaet61SOyp0eCaqqLd8468VhJ9ILTE7aqPzhkvYCZ1oVYLXIWTS
         r1gb9Oa7zsDYKHDE33xgWh2mpwtt9qDgdu7LjHCB1oxxBo2VemQx7S+2FLU8q8Vfpzo8
         6abRXC0/oIgu+XFIqF8NIlHEVP9II0A5Skuor0d0DIu+0RODVKfAZrZp61GAHpbVO9rX
         aYHQ==
X-Gm-Message-State: APjAAAWcVGvSymQh0vT4qLoM9J8+wfXsoU9jLOLo+RL+rWX06jREJ9ji
	bsloWzl5fbDC7xOqAnUZ16Fb4UFHRfJzXregDidbcQ==
X-Google-Smtp-Source: APXvYqwHEBEz9buHKmA5WasF38HpUbJBIM1RMFHqGuim3/MDmHBfKD6MeZ43PskjcE7Yf0EPwBqCWSk4mLF+sxGnacU=
X-Received: by 2002:a24:910b:: with SMTP id i11mr15920375ite.76.1558105585876;
 Fri, 17 May 2019 08:06:25 -0700 (PDT)
MIME-Version: 1.0
References: <1557993298-22205-1-git-send-email-xiaoyux.lu@intel.com>
 <049e489c-b58f-0fc5-1c66-8ad920d93979@redhat.com> <D827630B58408649ACB04F44C5100036258FB83E@SHSMSX107.ccr.corp.intel.com>
 <0a6b50d4-3837-a5e6-7f3a-36386c65d42b@redhat.com> <75b13a2a-f570-97e9-a7df-5e24b2a2b22c@redhat.com>
In-Reply-To: <75b13a2a-f570-97e9-a7df-5e24b2a2b22c@redhat.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:06:11 +0200
Message-ID: <CAKv+Gu-=StCw=dt2gCOGRDscPVTas-1LkPV2YZ-J857oHbvMoA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>, 
	"Lu, XiaoyuX" <xiaoyux.lu@intel.com>, "Ye, Ting" <ting.ye@intel.com>, 
	Leif Lindholm <leif.lindholm@linaro.org>, "Gao, Liming" <liming.gao@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 17 May 2019 at 15:17, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 05/17/19 15:04, Laszlo Ersek wrote:
> > On 05/17/19 07:11, Wang, Jian J wrote:
> >> Hi Laszlo,
> >>
> >> There's already a float library used in OpensslLib.inf.
> >>
> >> [LibraryClasses.ARM]
> >>   ArmSoftFloatLib
> >>
> >> The problem is that the below instance doesn't implement __aeabi_ui2d
> >> and __aeabi_d2uiz (I encountered this one as well)
> >>
> >>   ArmPkg\Library\ArmSoftFloatLib\ArmSoftFloatLib.inf
> >>
> >> I think we can update this library support those two APIs. So what about
> >> we still push the patch and file a BZ to fix this issue?
> >
> > I'm OK with that, but it will break ARM and AARCH64 platforms that
> > consume OpensslLib (directly or through BaseCryptLib), so this question
> > is up to Leif and Ard to decide.
>
> Correction: break ARM platforms only, not AARCH64.
>

We obviously need to fix this before we can upgrade to a new OpenSSL version.

Do we really have a need for the random functions? These seem the only
ones that use floating point, which the UEFI spec does not permit, so
it would be better if we could fix this by removing the dependency on
FP in the first place (and get rid of ArmSoftFloatLib entirely)