From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com
 [IPv6:2607:f8b0:4001:c0b::22b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 05BD71A1DF8
 for <edk2-devel@lists.01.org>; Thu,  4 Aug 2016 02:01:21 -0700 (PDT)
Received: by mail-it0-x22b.google.com with SMTP id f6so254626742ith.0
 for <edk2-devel@lists.01.org>; Thu, 04 Aug 2016 02:01:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=5sfCLT96GxAbcVmppGbsZwW6edfaIFnYRmZJfmGx6es=;
 b=id9ygvF2WulTs/PwDSCfHXH3o6HG3jkmmgHhIFepgY19dve+mgwBClRTlOYwcjzC/X
 gteBHBViqnLL6TAUDfNHxbovl5PEyvj2uk37zPFhkPOAipXI3kv/uGnCL9y69SnIPiiA
 VbmevzekKaI54qmXIMmK4nlWvJM4LWzNIg7+M=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=5sfCLT96GxAbcVmppGbsZwW6edfaIFnYRmZJfmGx6es=;
 b=IysJm868oqz6AAv1uHWtl5jvuoWJD495xUhHF3w7aW8EpIiYPVkJd9B0RoUFk+X0Ib
 dHmHKx11h5OM5+QFGbTfV+pKxKkuuY54+c8e5mIqjktCIE/RqZiUuDvOAdciudYE8lDR
 zt5D+xBedecjXjpoqjB8BqzaHdCvAi1z8/3KWEidCYpKOhTHONDflwVcPk3QUB5BMAi2
 1y+d2letBKRhhHdrnloDdm/LFGTrguxci+Z5TuCRhiXb0NC7CkeuAVI+gZoWD6HDrx+h
 dON1dd/l4Qj2pM7zsF+ODFbw44MFdtAF7TN7iWg2FkuJWCDnxvibAzUbx7psCRuAJoR9
 Xphg==
X-Gm-Message-State: AEkoouvm1QaS4/6E3Ak/dAMvFHSKxIqpQTEIxXBUKZMSYUvsTODG92poMZNaUsfgzC9CjzxuIXcWXFzbsKetyQwD
X-Received: by 10.36.7.209 with SMTP id f200mr73210380itf.29.1470301279246;
 Thu, 04 Aug 2016 02:01:19 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.36.204.195 with HTTP; Thu, 4 Aug 2016 02:01:18 -0700 (PDT)
In-Reply-To: <06C8AB66E78EE34A949939824ABE2B31033853EB@shsmsx102.ccr.corp.intel.com>
References: <1470300343-17287-1-git-send-email-ard.biesheuvel@linaro.org>
 <06C8AB66E78EE34A949939824ABE2B31033853AB@shsmsx102.ccr.corp.intel.com>
 <CAKv+Gu_pvmE1Bs_=eENdqN18sVZQ1v4Qmt4wr2HvVFt0LXdwqw@mail.gmail.com>
 <06C8AB66E78EE34A949939824ABE2B31033853EB@shsmsx102.ccr.corp.intel.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Thu, 4 Aug 2016 11:01:18 +0200
Message-ID: <CAKv+Gu-=VfK+q877_4-M4zhKx6QF5Zerk3cZxtLnAvH0YM2N1Q@mail.gmail.com>
To: "Shi, Steven" <steven.shi@intel.com>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>, "Gao,
 Liming" <liming.gao@intel.com>, 
 "Justen, Jordan L" <jordan.l.justen@intel.com>, 
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "mischief@offblast.org" <mischief@offblast.org>
Subject: Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2016 09:01:21 -0000
Content-Type: text/plain; charset=UTF-8

On 4 August 2016 at 10:58, Shi, Steven <steven.shi@intel.com> wrote:
> OK, it is. But it is a bit not very clear.
>

Did you read the elaborate comment block explaining that (and why) it
is appropriate to treat R_X86_64_PLT32 as a R_X86_64_PC32 relocation?
This is not generally true, but it is true for UEFI since we don't
support shared libraries.

So I think it is incorrect to simply duplicate the code for
R_X86_64_PC32 without mentioning that, and suggesting that the PLT
relocation receive some kind of treatment that is different.

Thanks,
Ard.