Re: [PATCH edk2-platforms v2 0/2] enable Secure96 mezzanine on ACPI systems

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Thu, 2 May 2019 at 17:40, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Thu, May 02, 2019 at 11:58:52AM +0200, Ard Biesheuvel wrote:
> > This series plumbs in the support for describing 96boards mezzanines
> > via ACPI, and uses it to add a description of the Secure96. Note that
> > the TPM is still missing at the moment, but the I2C crypto accelerators
> > and the GPIO LEDs are covered.
> >
> > Changes since v1:
> > - Don't rely on a ACPI device in the host platform's namespace to describe
> >   the GPIO lines - this prevents the mezzanine from using GPIOs as interrupts,
> >   and is generally far too restrictive. Since we need a hack (see below) for
> >   I2C anyway, just use the same method for the GPIO controller.
> > - I2C resources are described with a reference to the I2C controller via a
> >   string argument, which cannot be parameterized using PCDs like we do with
> >   GPIO interrupt numbers. (This is due to the fact that string PCDs are not
> >   expanded to true string literals by EDK2's AutoGen.h CPP magic). So add the
> >   default names (e.g., \_SB.I2C0) to Secure96.h, and permit a platform to
> >   override them if necessary by setting a scoped build option with a -D
> >   argument.
> >
> > Ard Biesheuvel (2):
> >   Platform/96Boards: add ACPI support to mezzanine/LS connector driver
> >   Platform/Secure96Dxe: add ACPI description of the LEDs and I2C
> >     peripherals
>
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks

Pushed as 639a2e38ca66..747e75cc3e67