From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=vgxKdDC/; spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193]) by groups.io with SMTP; Fri, 03 May 2019 07:07:01 -0700 Received: by mail-it1-f193.google.com with SMTP id l10so9261366iti.3 for ; Fri, 03 May 2019 07:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kmZQq5yLuWgAAZRwr9C4VAvK92edMNYwkUhSO75r+yM=; b=vgxKdDC/Pq2bFoBgygE1WO69PYPskHSGmAdiiZj7/viyyHNspu7GT4ogdyPj28BACv fv8V2y1z2Tra4853lJWfSSsffBF3X1N03izMjUu3PCX+shXsPYGqqwDu/fGYR+d19UQa C5u4CGlia/OJ/SLV1/ofwnEuB8F7kGPhQCq2eZgVSWr01OPld8no5M7NrRhFAb5hM5TG PeXfXkiuH8IiVXB5Fz7S64RBMSG/sahfX1slohO19SePNUxyhg2amS3Wc1gPOTK/fUN5 xLqELFYpYCQHKD+Bari7AgNN6E/SZcgTtyRzm8Kjyv9Y2rLlc7of4wtJf92pEwdZX7Z3 4Cjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kmZQq5yLuWgAAZRwr9C4VAvK92edMNYwkUhSO75r+yM=; b=AV+p0FQUI7sIOkb1lSmNr+F6T8vuTAE0glPpabWgYjUC5pn3Rvdu5jZ0Nol5+g3N1V TvvShXSzRKDD6sZYghVIa3xROxung2EaR3awrHao77LYfliAAewNiDblDSEMcUQjwCZa Tz4rd13ILdfujTWkQ4fJaKygawvcyCl4phjXtMMRn296hiOjjOhViokxeeHgmf0NyKga +SFGyBvlR4gVlzD3ua2NuG5AYatBR7IquxZ0saw/8r92VthIuJwqpHHlfQgTzibQuT9R meS9nBn6uwW+m7iC2TfkbXcRW42qMaSngBkQqC8KLReXQWP9PJgRGq0TDGcgGltCzHUU cc/w== X-Gm-Message-State: APjAAAXLaqhZS3dDlPe+CHe0ZkUPhtOfWrM0cVINmWB62GdJX88/0NdE 4ZVMFlRkxRXVop23wJ4fXOpN5o4JDJa704xcdsdLfA== X-Google-Smtp-Source: APXvYqz8P9aDiM37URUA604cqCgjmni3R6Id7mLacsT3VOC+ZOxvmHHr47+gafyr/Or9PRTAgy/mL34JCEcCp4UdYgo= X-Received: by 2002:a02:1dc7:: with SMTP id 190mr6779255jaj.62.1556892420792; Fri, 03 May 2019 07:07:00 -0700 (PDT) MIME-Version: 1.0 References: <20190502095854.6989-1-ard.biesheuvel@linaro.org> <20190502154035.wdsxba5r6kby5iyr@bivouac.eciton.net> In-Reply-To: <20190502154035.wdsxba5r6kby5iyr@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Fri, 3 May 2019 16:06:49 +0200 Message-ID: Subject: Re: [PATCH edk2-platforms v2 0/2] enable Secure96 mezzanine on ACPI systems To: Leif Lindholm Cc: edk2-devel-groups-io , Graeme Gregory Content-Type: text/plain; charset="UTF-8" On Thu, 2 May 2019 at 17:40, Leif Lindholm wrote: > > On Thu, May 02, 2019 at 11:58:52AM +0200, Ard Biesheuvel wrote: > > This series plumbs in the support for describing 96boards mezzanines > > via ACPI, and uses it to add a description of the Secure96. Note that > > the TPM is still missing at the moment, but the I2C crypto accelerators > > and the GPIO LEDs are covered. > > > > Changes since v1: > > - Don't rely on a ACPI device in the host platform's namespace to describe > > the GPIO lines - this prevents the mezzanine from using GPIOs as interrupts, > > and is generally far too restrictive. Since we need a hack (see below) for > > I2C anyway, just use the same method for the GPIO controller. > > - I2C resources are described with a reference to the I2C controller via a > > string argument, which cannot be parameterized using PCDs like we do with > > GPIO interrupt numbers. (This is due to the fact that string PCDs are not > > expanded to true string literals by EDK2's AutoGen.h CPP magic). So add the > > default names (e.g., \_SB.I2C0) to Secure96.h, and permit a platform to > > override them if necessary by setting a scoped build option with a -D > > argument. > > > > Ard Biesheuvel (2): > > Platform/96Boards: add ACPI support to mezzanine/LS connector driver > > Platform/Secure96Dxe: add ACPI description of the LEDs and I2C > > peripherals > > For the series: > Reviewed-by: Leif Lindholm > Thanks Pushed as 639a2e38ca66..747e75cc3e67