From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 420E821959CB2 for ; Thu, 28 Feb 2019 04:11:02 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id 9so4552366iog.8 for ; Thu, 28 Feb 2019 04:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P6icvaBV7HbpcSdthGQn8naczcltrVLeJ7vcolsD8kA=; b=vpE+bQzhBWeYwV8cPgrZYfWtW3GLKG2/IWEb1ZJBZKczdy4uRcUo4uwLcfmF3zb7hD zo/AZFj1HSMYlg/8wR1EWiBO6yVjzdLCUWFSwtckBz+n1SxSmOcE670elyncp5Kmn5XD q17TB/NivvZD5Ed99p/DdMEpBxDqY6zeX6RXt1c10Ta+ApA30oTjbR+ielLVtERaS92j +qEYMEkpllfvvyHC8lfxXebMUqWJeDd174V66NmzLrY6NHUrB8YnJybB9WfUbWoeyKEp HiAPxaMRQUgSX0m4He9l4Lnu9z6qdHA+Wgu4e/6e1xcEo1526WDekXUMFkXSJYm77fv7 0hTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P6icvaBV7HbpcSdthGQn8naczcltrVLeJ7vcolsD8kA=; b=IWROK3HcZ6swZRI/fkOjxlBfRzeseCJ8FyTvj+OzT+3vHOzaS/jdY1US3hmUxE0jMQ eqm7khTG1b9z7DF7Z2OREz6bjv8qjrkUD7aVPbwNDVgLP4P17u9DLrqaI8OzhpXW0LRm v00G9nggznqPr7OYwKXnDZf96Hw3RX+rZ17x3O4kEgsrwADqr+7RzGOqznTbiBwnLw65 816VaVtJWI7ThFlJS88MiXc7OEcrJg+AxjGGp7gNex4vOQLC6r02ZIkw+vVgbZGYHGJU iOKgGtjkZ4STMDT1ZOz9eNLutvMpmBvtfezO8CjPLg+pRMQX0y/+FAKB/nkLOe/2Ll+1 eTLQ== X-Gm-Message-State: APjAAAUsTmJtwllQDIbyCjsglAyIe9We0OOXAob0EqZLbtiadEkQjt3e Z0daMc/up4DsfVBgNe/H/phHxwDZCUm2TlO+Qph8+A== X-Google-Smtp-Source: APXvYqyepAxsXexC0avF5VuFX9odzcmSipOd9bkVnVk92M4pd5ZJ/mdfcwOY7akZ75eplrSKh9a3xm8xpi74jym5NhY= X-Received: by 2002:a6b:7b02:: with SMTP id l2mr5209090iop.60.1551355861750; Thu, 28 Feb 2019 04:11:01 -0800 (PST) MIME-Version: 1.0 References: <1551341112-21645-1-git-send-email-guoheyi@huawei.com> In-Reply-To: <1551341112-21645-1-git-send-email-guoheyi@huawei.com> From: Ard Biesheuvel Date: Thu, 28 Feb 2019 13:10:50 +0100 Message-ID: To: Heyi Guo Cc: "edk2-devel@lists.01.org" , wanghaibin 00208455 , Jian J Wang , Hao Wu , Laszlo Ersek , Julien Grall Subject: Re: [RFC 0/3] Enable runtime serial debug for ArmVirtQemu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 12:11:03 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 28 Feb 2019 at 09:06, Heyi Guo wrote: > > Serial port output is useful when debugging UEFI runtime services in OS runtime. > The patches are trying to provide a handy method to enable runtime serial port > debug for ArmVirtQemu. > > Cc: Jian J Wang > Cc: Hao Wu > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > > Heyi Guo (3): > MdeModulePkg/StatusCode: Add PCD to enable runtime serial debug > ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib > ArmVirtQemu: enable runtime debug by build flag > Hello Heyi, We have had this discussion before, and IIRC, the proposed solution was to use status codes. I'm not sure how that is supposed to work though - hopefully Laszlo or one of the MdeModulePkg maintainers can elaborate. > ArmVirtPkg/ArmVirt.dsc.inc | 6 ++ > ArmVirtPkg/ArmVirtQemu.dsc | 13 +++ > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 + > ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.c | 29 ++++-- > ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.h | 27 +++++ > ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf | 3 + > ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLibCommon.c | 27 +++++ > ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLibRuntime.c | 104 ++++++++++++++++++++ > ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLibRuntime.inf | 58 +++++++++++ > MdeModulePkg/MdeModulePkg.dec | 6 ++ > MdeModulePkg/MdeModulePkg.uni | 6 ++ > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.c | 2 +- > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf | 7 +- > 13 files changed, 279 insertions(+), 14 deletions(-) > create mode 100644 ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.h > create mode 100644 ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLibCommon.c > create mode 100644 ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLibRuntime.c > create mode 100644 ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLibRuntime.inf > > -- > 1.8.3.1 >