From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E304321E2BE4F for ; Tue, 29 Aug 2017 09:58:43 -0700 (PDT) Received: by mail-io0-x232.google.com with SMTP id d81so23228019ioj.4 for ; Tue, 29 Aug 2017 10:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=I584ld26kglmbCOtJ0gFELHJkGfmRKjvabXU2ACb4ao=; b=NAvdqOT5ZtuR9cgMySs4th7N7vnIDHp2DvzGPSrQEOvy8F/Eo0bbg7LEYuunUfddo1 8J1Ij0wGh+m3UtJqyaFIEus5PdWDNS5GbYx9z9SFHxKb9R2UyZng1EHYT3aOeo/5k5vu IOv7zSPFmbNmlYOUG6CAcjbX4V0F6uD3M5u7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=I584ld26kglmbCOtJ0gFELHJkGfmRKjvabXU2ACb4ao=; b=m03zMC8zIf/iuB6OMEpztV+5ebSHYFIkdJgInDQRjx+IwGb3fxMSZn3j/ubNVJhxJZ sps4F1WGEL0z8L5jF9YHjUiZvA7HTHC7W7KPQUzAErZtf1N3n993PVLJ6cpr+v5cSLFo PM++BysoHxGCLl9GRhEhb61XUqe/tYRuCsnFVmG3Bo2nPx6k7wtKrHZjn3OwbM0mwcrK u6Fg5s0DPm8nh7rThDcj6YtQx3QhsnkXqhkaAcPVRK0CRV6+QBbSKM9PggJXzPV3WcKj etRAHRSxPapBVoA7QruaMytTlCxbahEa/AzJe34kwlEnjRATIUjRJ+DRQHrw/i/rfeBU fl3Q== X-Gm-Message-State: AHYfb5jvmtjqWF6s7KHApc/I6nELpsFLSb0S2+x5IwSNNq7ORxuu5IxI rQr3oh2HWEKbob/bgZJ1fv+cpGHa0lSuYU5DnA== X-Received: by 10.36.178.87 with SMTP id h23mr2896653iti.128.1504026083935; Tue, 29 Aug 2017 10:01:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 10:01:23 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 29 Aug 2017 18:01:23 +0100 Message-ID: To: Marcin Wojtas Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 16:58:44 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 16:53, Marcin Wojtas wrote: > 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : >> On 29 August 2017 at 16:47, Marcin Wojtas wrote: >>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>> more abstract level. This allows the driver to be shared with >>>>> platforms that are cache coherent (by simply switching to another >>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>> EDK2. >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>> Signed-off-by: Ard Biesheuvel >>>> >>>> Ah, and there is the non-bogus fix :) >>>> Reviewed-by: Leif Lindholm >>> >>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>> >> >> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >> changes (which I will do today) > > Ok, please let know once it's available and also it would be great if > this patch could be shared via github repo. > The prerequisite patches for DmaLib are in EDK2 now. https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib