Re: [PATCH 0/4] OvmfPkg, ArmVirtPkg: add ACPI Test Support

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Sun, 25 Nov 2018 at 11:02, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Repo:   https://github.com/lersek/edk2.git
> Branch: acpi_test_support
>
> The feature is described in the first patch. Build OvmfPkg and
> ArmVirtPkg platforms with "--pcd PcdAcpiTestSupport=TRUE" to enable it.
>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Drew Jones <drjones@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (4):
>   OvmfPkg: introduce ACPI Test Support data structure and GUID
>   OvmfPkg/AcpiPlatformDxe: list missing lib classes for
>     QemuFwCfgAcpiPlatformDxe
>   OvmfPkg/AcpiPlatformDxe: add [Un]RegisterAcpiTestSupport() skeletons
>   OvmfPkg/AcpiPlatformDxe: fill in ACPI_TEST_SUPPORT at first
>     Ready-To-Boot
>

I'm not crazy about scraping memory, but since this is a test feature,
and since the hypervisor can be trusted to only scrape regions
populated with non-secure DRAM, I can live with it.

Regarding the GUID: i thought about perhaps using the XOR of two known
GUIDs, but bitwise negation involving a all-ones GUID amounts to the
same thing in the end, so whatever :-)

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>  OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h               |  10 ++
>  OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf          |   8 ++
>  OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c            | 119 ++++++++++++++++++++
>  OvmfPkg/AcpiPlatformDxe/EntryPoint.c                 |  24 +++-
>  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf |  10 ++
>  OvmfPkg/Include/Guid/AcpiTestSupport.h               |  67 +++++++++++
>  OvmfPkg/OvmfPkg.dec                                  |   6 +
>  7 files changed, 239 insertions(+), 5 deletions(-)
>  create mode 100644 OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c
>  create mode 100644 OvmfPkg/Include/Guid/AcpiTestSupport.h
>
> --
> 2.19.1.3.g30247aa5d201
>