From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A747921B02822 for ; Mon, 26 Nov 2018 09:21:27 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id l14so14434061ioj.5 for ; Mon, 26 Nov 2018 09:21:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nodjT3/XPtIYo096GBWVYc+qTq65aipx+3QFRT3092E=; b=Okomrz3/oq7wMqZDqv5uVxhMjFieQUEREi3X2SkGSGwaxEO9vFbhywxwctaRO9LixY +0xrYzXIIyxOyRygtvlOfXjZox4gGltO339EAzRsh7OC9GhUW2gQg4KQYbTgFgTRE9Df twNA9H71VUCD0AO0GoK7MluqxrhqX5xMc+yo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nodjT3/XPtIYo096GBWVYc+qTq65aipx+3QFRT3092E=; b=jxC9o2PNjkqklT2rYRj+UdYYw81dy1RYtE9cqJ3fvRoosgsPiJRhCEtg4wNlWp2gMc VYkIueqr/HKqV8ReWwxaJOlKTFnqESjmFx2XBmwHHMsHgc0INNJP92R9HCQHS0kF5XGw USY0EJ0uvE/fvWlQyGl+2x7vjpQgP6JHXoTEUY1CNbE24xwNyxbxoQFKQSNWZ/FfVwIi BvYOjBoL1yXb75Tf4M0sYyeX7ZzGiuI9Uo6ly0oFkpG5/Xht5dc80xPvMsZQkL0R8ip7 RTQq3j3nm0rs3BYolHOo05InatB5kSPvQaa5Ibxv3YfHhQZKlP7oP/w5cT3zs1g/G7vk ZEGg== X-Gm-Message-State: AA+aEWZTPV0SOKYQubrQR7WZzvu1SBf3I2d0jdapvRAZV8uTHy6x1Ahc xZUcBSNz7va93GENfEcEBnFIls9Fn9e9w2smBa76czTeVp4= X-Google-Smtp-Source: AFSGD/X1ajIz6FOWRVMKRsKUSbF4WbFTKsQI8nFKKDZnrypUDbXjO6dSERH3nNh8elmg52DyH6MXXGS2anIIMW6hEdg= X-Received: by 2002:a5d:8402:: with SMTP id i2mr12930533ion.173.1543252886700; Mon, 26 Nov 2018 09:21:26 -0800 (PST) MIME-Version: 1.0 References: <20181125100152.25675-1-lersek@redhat.com> In-Reply-To: <20181125100152.25675-1-lersek@redhat.com> From: Ard Biesheuvel Date: Mon, 26 Nov 2018 18:21:15 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Anthony PERARD , Andrew Jones , Igor Mammedov , Jordan Justen , Julien Grall , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH 0/4] OvmfPkg, ArmVirtPkg: add ACPI Test Support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 17:21:27 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 25 Nov 2018 at 11:02, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > Branch: acpi_test_support > > The feature is described in the first patch. Build OvmfPkg and > ArmVirtPkg platforms with "--pcd PcdAcpiTestSupport=3DTRUE" to enable it. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Drew Jones > Cc: Igor Mammedov > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daud=C3=A9 > > Thanks, > Laszlo > > Laszlo Ersek (4): > OvmfPkg: introduce ACPI Test Support data structure and GUID > OvmfPkg/AcpiPlatformDxe: list missing lib classes for > QemuFwCfgAcpiPlatformDxe > OvmfPkg/AcpiPlatformDxe: add [Un]RegisterAcpiTestSupport() skeletons > OvmfPkg/AcpiPlatformDxe: fill in ACPI_TEST_SUPPORT at first > Ready-To-Boot > I'm not crazy about scraping memory, but since this is a test feature, and since the hypervisor can be trusted to only scrape regions populated with non-secure DRAM, I can live with it. Regarding the GUID: i thought about perhaps using the XOR of two known GUIDs, but bitwise negation involving a all-ones GUID amounts to the same thing in the end, so whatever :-) Reviewed-by: Ard Biesheuvel > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 10 ++ > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 ++ > OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c | 119 +++++++++++++= +++++++ > OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 24 +++- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 10 ++ > OvmfPkg/Include/Guid/AcpiTestSupport.h | 67 +++++++++++ > OvmfPkg/OvmfPkg.dec | 6 + > 7 files changed, 239 insertions(+), 5 deletions(-) > create mode 100644 OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c > create mode 100644 OvmfPkg/Include/Guid/AcpiTestSupport.h > > -- > 2.19.1.3.g30247aa5d201 >