Re: [PATCH] ArmPlatformPkg ArmVirtPkg: reorganize PL011 code

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 16 November 2017 at 17:36, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Nov 16, 2017 at 05:12:16PM +0000, Ard Biesheuvel wrote:
>> The PL011 code in ArmPlatformPkg is organized in a weird way: there is
>> a single PL011Uart.h header file under Include/Drivers containing both
>> register definitions and function entry points. The PL011Uart library
>> itself is in Drivers/ but it is actually a library.
>>
>> So let's clean this up: add a new PL011UartLib library class and associated
>> header file containing only the library prototypes, and move the library
>> itself under Library/ using a new GUID, with the register definitions moved
>> into a local header file.
>>
>> Note that we need to retain the old implementation for out of tree
>> platforms,
>
> s/need to//
>
> Do we need to?

At least until we switch over edk2-platforms, yes.

> I mean, we could, and give a bit of a warning for people to switch
> over. But does the change actually entail anything more than pointing
> to the new .inf location?

No.

> If not, we're just moving the point at
> which platforms fail and have to modify their .dsc/.fdf.
>
> That said, I'm not religiously opposed to a grace period - but I
> don't want the old version hanging around to get included in the next
> UDK release.
>
> I _would_ prefer to see the ArmVirtPkg change as a separate patch.
> Especially if the old copy is kept around.
>

Fair enough.

> Nice bit of cleanup though.
>
> /
>     Leif