From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 346002035A7AB for ; Thu, 16 Nov 2017 09:34:03 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id 71so6028636ior.7 for ; Thu, 16 Nov 2017 09:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KFRZZsbHwxKLPVX8n8FMQ+e0/SmFF0Yp9Bmyv6CPJ4A=; b=gz4rHuc6p2cQOz+a2K8lPwBTvtQ+UeDFpALR40tcBmqmdHoH0IdzofgTYM4/BkXVeK VlM+gDLpTsxVJy9+XWqwMIMGswN6foXsa4qiP+yMmLZLHjfb8ki+dCI7m8AFXOglwmTF YDY9zVgDEiircx9ngmMC5aPw5m6RbzL72e5Wg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KFRZZsbHwxKLPVX8n8FMQ+e0/SmFF0Yp9Bmyv6CPJ4A=; b=L/N2UKCPc6PXtQJs2nvPyOGfU35u8KMIDaM7LTiCGwjgno6jIDad2CylaRMOtpVf8N HhHbyZZYK4TW2HOsAOYeTQv9XFY5hNWUcpVCOlKjTpVSFbAikiRc2rJlICKloJDgpTgA P5PGuQ+9ITjX4DoOBJR8Pp4d1HQ/BgyRTrDSrmqMh2iATihSDmO94MP1d+ejc7wSMzI7 7IeBJshaV+2NWb4djZEpr82dxl96zsdSPDhBQzORaXnUVaUDzdc7Dof7ojtnjcKQrZtP ME1B8TterTG3yMalwMLnTtihxW8L+27BrZ/I4or5galLtXA9on+vZ33E09sd3Wu1kC90 l28A== X-Gm-Message-State: AJaThX6cgvikDDJhi6sis1fY5Snr9/OXbMQ6keALv2jnx2K9ObQ5t9c/ 5UfAEfbLLBMUiiaTY7sS1zh6PtKUzWSNDmwn3/Q9eVoY X-Google-Smtp-Source: AGs4zMbJ3XIb7BOtPSpEcIBMLZ63jLSWjyazXisoJ8y3hcDAnZciA2YKKKOVftA9knTeWH5ULmBG+e+Qv8mhis8IlSA= X-Received: by 10.107.151.19 with SMTP id z19mr2525000iod.248.1510853890965; Thu, 16 Nov 2017 09:38:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.3 with HTTP; Thu, 16 Nov 2017 09:38:10 -0800 (PST) In-Reply-To: <20171116173620.yovvab2cuqiqyr5l@bivouac.eciton.net> References: <20171116171216.7566-1-ard.biesheuvel@linaro.org> <20171116173620.yovvab2cuqiqyr5l@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 16 Nov 2017 17:38:10 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] ArmPlatformPkg ArmVirtPkg: reorganize PL011 code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 17:34:03 -0000 Content-Type: text/plain; charset="UTF-8" On 16 November 2017 at 17:36, Leif Lindholm wrote: > On Thu, Nov 16, 2017 at 05:12:16PM +0000, Ard Biesheuvel wrote: >> The PL011 code in ArmPlatformPkg is organized in a weird way: there is >> a single PL011Uart.h header file under Include/Drivers containing both >> register definitions and function entry points. The PL011Uart library >> itself is in Drivers/ but it is actually a library. >> >> So let's clean this up: add a new PL011UartLib library class and associated >> header file containing only the library prototypes, and move the library >> itself under Library/ using a new GUID, with the register definitions moved >> into a local header file. >> >> Note that we need to retain the old implementation for out of tree >> platforms, > > s/need to// > > Do we need to? At least until we switch over edk2-platforms, yes. > I mean, we could, and give a bit of a warning for people to switch > over. But does the change actually entail anything more than pointing > to the new .inf location? No. > If not, we're just moving the point at > which platforms fail and have to modify their .dsc/.fdf. > > That said, I'm not religiously opposed to a grace period - but I > don't want the old version hanging around to get included in the next > UDK release. > > I _would_ prefer to see the ArmVirtPkg change as a separate patch. > Especially if the old copy is kept around. > Fair enough. > Nice bit of cleanup though. > > / > Leif