From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.1341.1585761457292362024 for ; Wed, 01 Apr 2020 10:17:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=v+C7j8rL; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id i19so624031wmb.0 for ; Wed, 01 Apr 2020 10:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p0XFXan1NS3agjEgZmsYmmqu0teaOLNjt8Su7Ygh9+Q=; b=v+C7j8rL/Eirv+ClqKYiGbesyUhaHp9IvebdVu1r96KgdwLr7j1fGC1YrBuGsu3c9g y7YiAqnmnyyUB2/S2N483Gqsd5mWXLPBhaEdj+ZmUc3AR2XmwGgujpm8ayfT29Oq4Xyk UEFipB92jZIKbzAFM/k1JPcVnjpqJWjoD/oonSocP19TbxhfaZOZBaq7hoNfI4IzTNxV J+gNx2ovr7Y/oRPXfzFQoybl1hn9GVdphrHuv+l/uMHkVr8zzCzM22pUnOqXjXSkV8CU 5R61a+jNSy4ZXPzpgGc9Eet7wltxE/RQMcXnYm73ho6UCjMtqUEi8URtO9mAUnBqstyS 6l1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p0XFXan1NS3agjEgZmsYmmqu0teaOLNjt8Su7Ygh9+Q=; b=SaiD4soSVOuLQnMyjfPyzfZgGu/FS1ARIxwE5UwbTuy+T3Vw2Ldz5YQZXCDMbBRKWb +NXG/htfiIu/4wgvlAWbkAIwyuiKrREWjTWx7mcjYyTtFZ0kCZ86dsBS/SmjmFMOGmOL evGT41k87hqm29K5W5Z3pZx5pVc+CR0LwH+MZ0S0AOmGNvexFuEuTHCszoXwbMwJZeIc etmJCXbjcFKgmYNW9C5j3Quj+WjO4g2Z6cRy/oeGKnjizu449st+PcXJYfO2paTO2pPH xWeu9wiDyNB3AoRM9tYaqpWPXu4ktCyw6DwrRv3mtycUzPYZeFr+Xvchp0v9a6A4/LOx kx8w== X-Gm-Message-State: AGi0PuaPTCjzpjXHjxJn1HLpxx5KnEyzVClliathJbLWIBvWnx//WuDv geyfeIvBVJlk3tuCmV0MV+2nvIVZj+yRZcaeK3v+sA== X-Google-Smtp-Source: APiQypKLlh1s7DBeUJw282BOKw0ATaVCUwPEudunCHfdgVimWV9axUNjJY90HsCeQTTj2/OCDgHL7/+ndBuKPhZD9Tk= X-Received: by 2002:a1c:6285:: with SMTP id w127mr5617687wmb.133.1585761455763; Wed, 01 Apr 2020 10:17:35 -0700 (PDT) MIME-Version: 1.0 References: <20200326102443.748-1-ard.biesheuvel@linaro.org> <74D8A39837DF1E4DA445A8C0B3885C503F9A0997@shsmsx102.ccr.corp.intel.com> <216623fab6344881b9958359a1d99f80@intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 1 Apr 2020 19:17:24 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table To: "Gao, Liming" , "Wu, Hao A" , Jian J Wang , "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Yao, Jiewen" , Laszlo Ersek , Leif Lindholm , "Ni, Ray" , Bret Barkelew Content-Type: text/plain; charset="UTF-8" On Mon, 30 Mar 2020 at 19:57, Ard Biesheuvel wrote: > > (adding Jian and Hao) > > Thanks for the acks, and apologies for failing to cc the MdeModulePkg > maintainers. > > Jian, Hao, do you have any opinion on this series? > Jian, Hao, Liming, Michael, It is not always clear to me how you at Intel divide up the maintainer duties between yourselves. Liming and Jiewen have acked this entire series, but they are not the MdeModulePkg maintainers, so I assume either Jian or Hao should approve it as well before i can proceed with it. If this is the case, could Jian and Hao please acknowledge that they read this email, and perhaps indicate a timeframe within which they will be able to give their verdict on these changes? Thanks, Ard. > > > On Mon, 30 Mar 2020 at 15:42, Gao, Liming wrote: > > > > Ack-by: Liming Gao > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > > > Sent: Friday, March 27, 2020 1:01 PM > > > To: Ard Biesheuvel ; devel@edk2.groups.io > > > Cc: Laszlo Ersek ; Leif Lindholm ; Kinney, Michael D ; Ni, Ray > > > ; Bret Barkelew > > > Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table > > > > > > Acked-by: Jiewen Yao > > > > > > I cannot remember if there is windows OS still using the properties table. > > > Maybe Microsoft people can comment. > > > > > > If no, I agree we can remove the old code. > > > > > > > > > > > > > -----Original Message----- > > > > From: Ard Biesheuvel > > > > Sent: Thursday, March 26, 2020 6:25 PM > > > > To: devel@edk2.groups.io > > > > Cc: Ard Biesheuvel ; Laszlo Ersek > > > > ; Leif Lindholm ; Kinney, Michael D > > > > ; Ni, Ray ; Yao, Jiewen > > > > ; Bret Barkelew > > > > Subject: [PATCH 0/4] remove generation of EFI properties table > > > > > > > > The EFI properties table is broken by design, deprecated, and seems to be > > > > causing confusion as it is unclear to some how it differs from the memory > > > > attributes table (which supersedes it). So let's get rid of the code that > > > > generates it entirely, along with the GUID definitions, PCDs etc. > > > > > > > > Due to how the two implementations are intertwined, patch #2 makes the > > > > minimal changes required to stop producing the table (and to allow patch > > > > #3 to remove the associated definitions from MdePkg). Patch #4 is optional > > > > and merges the code together. > > > > > > > > Cc: Laszlo Ersek > > > > Cc: Leif Lindholm > > > > Cc: Michael D Kinney > > > > Cc: Ray Ni > > > > Cc: Jiewen Yao > > > > Cc: Bret Barkelew > > > > > > > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633 > > > > > > > > Ard Biesheuvel (4): > > > > OvmfPkg: remove handling of properties table > > > > MdeModulePkg: disable properties table generation but retain the code > > > > MdePkg: remove PropertiesTable GUID > > > > MdeModulePkg/DxeCore: merge properties table routines into MAT > > > > handling > > > > > > > > MdeModulePkg/Core/Dxe/DxeMain.h | 9 - > > > > MdeModulePkg/Core/Dxe/DxeMain.inf | 3 - > > > > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 1 - > > > > .../Core/Dxe/Misc/MemoryAttributesTable.c | 1226 ++++++++++++++- > > > > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 1 - > > > > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1373 ----------------- > > > > MdeModulePkg/MdeModulePkg.dec | 24 - > > > > MdeModulePkg/MdeModulePkg.uni | 21 - > > > > MdePkg/Include/Guid/PropertiesTable.h | 31 - > > > > MdePkg/MdePkg.dec | 3 - > > > > OvmfPkg/OvmfPkgIa32.dsc | 1 - > > > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > > > > OvmfPkg/OvmfPkgX64.dsc | 1 - > > > > OvmfPkg/OvmfXen.dsc | 1 - > > > > OvmfPkg/PlatformPei/Platform.c | 1 - > > > > OvmfPkg/PlatformPei/PlatformPei.inf | 1 - > > > > 16 files changed, 1222 insertions(+), 1476 deletions(-) > > > > delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c > > > > delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h > > > > > > > > -- > > > > 2.17.1 > > > > > > > > > > >