From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C6E9321A1099A for ; Thu, 30 Nov 2017 05:11:47 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id d16so8389369itj.1 for ; Thu, 30 Nov 2017 05:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8mNomqdNKl5QniLuMJDfZn1iExNHOkgIB2mJlwghkds=; b=H6c/zXvOZZmoqTOdxyx50jrInmQfTpIn7MFeDtgTwPC0dMLk77xgx+7lpjO64PveX6 L03zufVsbP2KeRXdRd8oe3cLq5Z0TfXOoNw68XsxrmBV6sOhtnZNjFHf/O8fViGc+i3g ydEi0MznYfzOElP4oFslsx/8IFPWeu2ejUHnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8mNomqdNKl5QniLuMJDfZn1iExNHOkgIB2mJlwghkds=; b=bHUJbPob8ZhU0eNpElnfkgh2uUA2PmEzA8OsK7M23+/M03xVFm37x5UV7QSohrKm9D IFSL1MRqMjCCQw7fxIlMeuyC/khm5/pBi+ogciBiqusSoM9wY/itOyzoqSHvZHx5UO8E UpMd8PIMjJBonrzhlmrKLoc/KFz7XEfm/QuWGZbQ8LgkB+9yvcHjwG0aSuzBuj2LCEqA jLcWrnOi9GrHSCVtx43KHqC7VoJVUlSQtfgdW4jvU8yF784HmhjaJFyMLd9PszzcB23I O0yevqqbOFLx/a/nUSGR2wUUntJ8Rw46xBKZLMKNicEoA7cSGAKD/vK3CViDOeVOb+uc OwjQ== X-Gm-Message-State: AJaThX6l+49F+ENtq8iXJGY1FgGzeW9CxnAqK+nR/teo+Hbx9epvo4Ym dKKxTjYGePh8haHdkF7Gs95dLxRKB2dH1iadQdw/MQ== X-Google-Smtp-Source: AGs4zMbEcKdyY4RS2AV1hIH1JfnFdbHN0uZuAcfFAaqmzMUWHuaxo4KmIcvjl7OW/21P2ktcx5H9bzys4+E/s6KiAr8= X-Received: by 10.36.78.212 with SMTP id r203mr3036838ita.58.1512047772383; Thu, 30 Nov 2017 05:16:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Thu, 30 Nov 2017 05:16:11 -0800 (PST) In-Reply-To: References: <20171129101500.288384-1-ruiyu.ni@intel.com> <20171129101500.288384-3-ruiyu.ni@intel.com> <751c492a-26bc-49a5-deb7-80ef44a94953@redhat.com> From: Ard Biesheuvel Date: Thu, 30 Nov 2017 13:16:11 +0000 Message-ID: To: Laszlo Ersek Cc: Ruiyu Ni , "edk2-devel@lists.01.org" Subject: Re: [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 13:11:48 -0000 Content-Type: text/plain; charset="UTF-8" On 30 November 2017 at 12:22, Laszlo Ersek wrote: > On 11/29/17 14:53, Laszlo Ersek wrote: >> Ray, >> >> On 11/29/17 11:14, Ruiyu Ni wrote: >>> The TFTP command was converted from a NULL class library >>> instance to a dynamic shell command in commit 0961002352e9. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ruiyu Ni >>> Reviewed-by: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Julien Grall >>> --- >>> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++---- >>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- >>> ArmVirtPkg/ArmVirtXen.fdf | 3 ++- >>> 3 files changed, 11 insertions(+), 6 deletions(-) >> >> Can you please incorporate points (2) and (3) as well, from my v3 review? >> >> https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html > > I fixed up the commit message as described above. > > I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen > platforms, with the patch applied, for ARM and AARCH64. > > [lersek@redhat.com: extend commit message] > Reviewed-by: Laszlo Ersek > Build-tested-by: Laszlo Ersek > > Commit 59fcf0706bf4. > Thanks for taking care of this. The build had been broken long enough