From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 36BA7209831EA for ; Thu, 12 Jul 2018 23:46:03 -0700 (PDT) Received: by mail-it0-x241.google.com with SMTP id l16-v6so10152900ita.0 for ; Thu, 12 Jul 2018 23:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5YvteYE1+hYqz14KbYldmdxwWKG7FUsCZZVdX8jmKHU=; b=Xh1RFU10w6aqrK18nL+G1jEPINI4s6z00EEApl4GVgoT27Cg9+I8Sa6kAgM0FDN1Iz 3jV+1osMARJcJYFfQkpLl3Y/hYnXgFWmp2yX1SYWqo99zF4v7SFfqI1nL+P9lIP5xI0v cnr8CFdGsl2P/QFoMNaI4RHTRU5CuwMJgm8nM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5YvteYE1+hYqz14KbYldmdxwWKG7FUsCZZVdX8jmKHU=; b=YoN/l6jqxFhH103S+87N3Pnijn3OTmyb9kB47KBIeJxDQCRdaJV1c3JppgtERq6u8P kMFdGMPSJqBelKqjYOQ6iYuke2/yB41j2W93QgMchP6t0Jz/JQpqqk/0w8ALI8Vx3zlh +IXd9tYss+rpoFl/G1w3V1kHQ/NgN4efK3qdiuY5zwgedRaqIm+3C9XOpOK2s66Nvice gPDEMcRcFt+0S009GQKmLimcNTFr9KwpM8JBfaNuMHl1MBafBjlvHcac5MiVyJYvRM9u I1/D0taRKjzZa8HxeWVdghv4lCk4EZUlfxk3Wo4hWeFpSruM1t7SBsP6pxe7UskWg/R2 R2mg== X-Gm-Message-State: AOUpUlGHaxJc26UMXrUhVW6sMlk1B3On6Y0qQ4e5vn3doh/lLo021G0G q6gfBOYEZjXKqYuwwlTvTFPHgqq6qViK/wzCIa9D+g== X-Google-Smtp-Source: AAOMgpe8Gf7bwZ5HQCVIDIyXh0OynX6uIo6rpxJ4tTOqWS1CHxEOoqLxyKS0eRreRN+ldiLucg8hpiVcTpYahNA3Too= X-Received: by 2002:a24:d7c5:: with SMTP id y188-v6mr3765142itg.50.1531464362609; Thu, 12 Jul 2018 23:46:02 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Thu, 12 Jul 2018 23:46:02 -0700 (PDT) In-Reply-To: <1443c4db-6b50-c971-9e18-2b052a19515a@linaro.org> References: <20180704075117.7427-1-ming.huang@linaro.org> <20180704075117.7427-2-ming.huang@linaro.org> <1443c4db-6b50-c971-9e18-2b052a19515a@linaro.org> From: Ard Biesheuvel Date: Fri, 13 Jul 2018 08:46:02 +0200 Message-ID: To: Ming Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo Subject: Re: [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 06:46:03 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 12 July 2018 at 10:50, Ming wrote: > > > =E5=9C=A8 11/07/2018 22:19, Ard Biesheuvel =E5=86=99=E9=81=93: >> On 4 July 2018 at 09:51, Ming Huang wrote: >>> The edk2 commit bacfd6e let CpuDxe running latter. >>> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >>> gDS->SetMemorySpaceAttributes is invoked by some drivers. >>> >>> This issue can solve by adding Depex on gEfiCpuArchProtocolGuid >>> to RealTimeClockLib. >>> >> >> If this is the case, why do we still need the APRIORI DXE section? >> > > This APRIORI DXE will be removed in V3. > > The new PciHostBridge which is developed by Heyi.Guo will add in V3. > OK, so should I wait for the v3 series then? >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ming Huang >>> Signed-off-by: Heyi Guo >>> --- >>> Platform/Hisilicon/D03/D03.fdf = | 4 ++++ >>> Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeCl= ockLib.inf | 2 ++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D0= 3.fdf >>> index 1383aa1091..73e2b7e958 100644 >>> --- a/Platform/Hisilicon/D03/D03.fdf >>> +++ b/Platform/Hisilicon/D03/D03.fdf >>> @@ -146,6 +146,10 @@ READ_STATUS =3D TRUE >>> READ_LOCK_CAP =3D TRUE >>> READ_LOCK_STATUS =3D TRUE >>> >>> + APRIORI DXE { >>> + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >>> + } >>> + >>> INF MdeModulePkg/Core/Dxe/DxeMain.inf >>> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >>> >>> diff --git a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS32= 31RealTimeClockLib.inf b/Platform/Hisilicon/D03/Library/DS3231RealTimeClock= Lib/DS3231RealTimeClockLib.inf >>> index 319c35c724..ae7116dc31 100644 >>> --- a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealT= imeClockLib.inf >>> +++ b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealT= imeClockLib.inf >>> @@ -46,3 +46,5 @@ >>> >>> [Pcd] >>> >>> +[Depex] >>> + gEfiCpuArchProtocolGuid >>> -- >>> 2.17.0 >>>