Re: [PATCH v4 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 12 January 2018 at 11:10, Pete Batard <pete@akeo.ie> wrote:
> On 2018.01.12 09:58, Ard Biesheuvel wrote:
>>>>
>>>> So, to summarise, I would much prefer if we could keep most of the
>>>> current patch, and simply use the following where needed:
>>>>
>>>> AREA  s___aeabi_ldivmod, CODE, READONLY, ARM AREA  s___aeabi_llsr,
>>>> CODE, READONLY, ARM AREA  s___aeabi_uldivmod, CODE, READONLY,
>>>> ARM
>>>>
>>>
>>> Agreed, this is fine so long as we agree on the definition of "where
>>> needed".  In general I would expect each independent assembly function to
>>> have its own AREA directive (e.g. math functions).  In some cases there will
>>> clearly be a collection of dependent functions that would be better served
>>> by a single area directive (e.g. MMU initialization functions).
>>>
>>> Much Thanks!
>>>
>>> Eugene
>>>
>>
>> Agreed.
>
>
> Okay.
>
> Introducing/grouping/reviewing the code areas goes beyond the scope of what
> I am planning to do for this proposal, especially as the current goal is to
> leave RVCT with as little disturbance as possible, even if some improvements
> might be applied...
>
> So the only thing I am planning to do with the AREA's right now is have them
> under the exact same name they would have used with the RVCT_... macros.
>

That's fine.

> I'll send a new patch to that effect in a couple hours.
>
> Regards,
>
> /Pete

Thanks.