From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0AB12220D200 for ; Fri, 12 Jan 2018 05:20:03 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id v30so5840973iov.7 for ; Fri, 12 Jan 2018 05:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xzyog2dqcaq3lttNgZaEjuWJqVLCNfVkrnf2RDOAB1U=; b=EsCsFT76seeNb+ozEmrF+fXNQBY5W49bi5wAMTgOIQyDLviYxxcDrIzujjwr/srwva KrmFCkfIf5g6MMmaONB8px/noE6eM/wF0i+c0wlO3/5pUOvVbfBENItCOoS4z/q4UhOp +SsoWspQ9aiHIjVfRyOm6OqSVKX4TLRtgBFB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xzyog2dqcaq3lttNgZaEjuWJqVLCNfVkrnf2RDOAB1U=; b=BJIgf76lFOgiU8L+ycJry+d4ttr+hDDqc0g6o7V8l/HNDTvcLYQOecGlQb3XG7DbFO XBPhhO8fghwyDMOgvv9n6Q8RhA6X+QE/O0BYqQj0qtKf1RqGNxTpoaAlSSX02QD5kesw EpCbH50P79KYUfzFbV5KC0bqNZeJA1sDQWmdcdMJ5ALobVyq83lde/wHWxbpMdfMjr2r IMSsC8sjCFuDDQoA0L1UFDAyLxQJlX5rcVPdjltHikfTq++sBAE46k84lKSPS8gISuFJ Dl0AJJll0K8N0eTaiKf37mwifPp2eJY1VLBiTDH3U/XVS6hjsAQsJZjb9/mXGYvEpz7v R+Og== X-Gm-Message-State: AKGB3mKaTncB0l58EIkN6R0hfjSCjY4/REch02lhmfxobKwQsUb3GlpR X/dwnnBiH9m0uqW5pyee4UeKy41lRRHmvCfadFXHyA== X-Google-Smtp-Source: ACJfBov8Qo2srHj34EC5h+6r61lPiM0beeHI43kVfiQ3HtORSnqG8Vq7lZn3+td3bmD08bGiHQb607Gf6M7pxWewgyw= X-Received: by 10.107.160.196 with SMTP id j187mr26229676ioe.186.1515763517682; Fri, 12 Jan 2018 05:25:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.37.197 with HTTP; Fri, 12 Jan 2018 05:25:17 -0800 (PST) In-Reply-To: References: <20180110162644.11208-1-pete@akeo.ie> <20180110162644.11208-5-pete@akeo.ie> <5ccd6f32-ee75-57e2-75f0-1fe14cba6b05@akeo.ie> From: Ard Biesheuvel Date: Fri, 12 Jan 2018 13:25:17 +0000 Message-ID: To: Pete Batard Cc: "Cohen, Eugene" , "edk2-devel@lists.01.org" , "Gao, Liming" Subject: Re: [PATCH v4 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 13:20:04 -0000 Content-Type: text/plain; charset="UTF-8" On 12 January 2018 at 11:10, Pete Batard wrote: > On 2018.01.12 09:58, Ard Biesheuvel wrote: >>>> >>>> So, to summarise, I would much prefer if we could keep most of the >>>> current patch, and simply use the following where needed: >>>> >>>> AREA s___aeabi_ldivmod, CODE, READONLY, ARM AREA s___aeabi_llsr, >>>> CODE, READONLY, ARM AREA s___aeabi_uldivmod, CODE, READONLY, >>>> ARM >>>> >>> >>> Agreed, this is fine so long as we agree on the definition of "where >>> needed". In general I would expect each independent assembly function to >>> have its own AREA directive (e.g. math functions). In some cases there will >>> clearly be a collection of dependent functions that would be better served >>> by a single area directive (e.g. MMU initialization functions). >>> >>> Much Thanks! >>> >>> Eugene >>> >> >> Agreed. > > > Okay. > > Introducing/grouping/reviewing the code areas goes beyond the scope of what > I am planning to do for this proposal, especially as the current goal is to > leave RVCT with as little disturbance as possible, even if some improvements > might be applied... > > So the only thing I am planning to do with the AREA's right now is have them > under the exact same name they would have used with the RVCT_... macros. > That's fine. > I'll send a new patch to that effect in a couple hours. > > Regards, > > /Pete Thanks.