Re: [PATCH 13/37] EmbeddedPkg: Removing ipf which is no longer supported from edk2.

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 13 June 2018 at 05:44, chenc2 <chen.a.chen@intel.com> wrote:
> Removing rules for Ipf sources file:
> * Remove the source file which path with "ipf" and also listed in
>   [Sources.IPF] section of INF file.
> * Remove the source file which listed in [Components.IPF] section
>   of DSC file and not listed in any other [Components] section.
> * Remove the embedded Ipf code for MDE_CPU_IPF.
>
> Removing rules for Inf file:
> * Remove IPF from VALID_ARCHITECTURES comments.
> * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section.
> * Remove the INF which only listed in [Components.IPF] section in DSC.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> * Remove any IPF sepcific sections.
>
> Removing rules for Dec file:
> * Remove [Includes.IPF] section from Dec.
>
> Removing rules for Dsc file:
> * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC.
> * Remove any IPF specific sections.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: chenc2 <chen.a.chen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  .../Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf     |  2 +-
>  EmbeddedPkg/EmbeddedPkg.dsc                               | 15 ++-------------
>  EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf       |  2 +-
>  EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf           |  2 +-
>  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf                 |  2 +-
>  5 files changed, 6 insertions(+), 17 deletions(-)
>
> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf
> index d6bbf6932a..ba8da8c950 100644
> --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf
> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf
> @@ -25,7 +25,7 @@
>  #
>  # The following information is for reference only and not required by the build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF ARM AARCH64
> +#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64
>  #
>  #  DRIVER_BINDING                = gVirtualKeyboardDriverBinding
>  #  COMPONENT_NAME                = gVirtualKeyboardComponentName
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index e6fad5e58b..bfbeea7f0b 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -27,7 +27,7 @@
>    PLATFORM_VERSION               = 0.1
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/Embedded
> -  SUPPORTED_ARCHITECTURES        = IA32|X64|IPF|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE
>    SKUID_IDENTIFIER               = DEFAULT
>
> @@ -199,17 +199,6 @@
>    gEmbeddedTokenSpaceGuid.PcdTimerVector|7
>    gEmbeddedTokenSpaceGuid.PcdTimerPeriod|100000
>
> -[PcdsFixedAtBuild.IPF]
> -  gEfiMdePkgTokenSpaceGuid.PcdIoBlockBaseAddressForIpf|0x0ffffc000000
> -
> -#
> -# This makes it so you can source level debug with NT32. VC++ debugger limitiation!
> -#
> -#[BuildOptions]
> -#  DEBUG_*_IA32_DLINK_FLAGS = /EXPORT:InitializeDriver=$(IMAGE_ENTRY_POINT) /ALIGN:4096 /SUBSYSTEM:CONSOLE
> -#  RELEASE_*_IA32_DLINK_FLAGS = /ALIGN:4096
> -#  *_*_IA32_CC_FLAGS = /D EFI_SPECIFICATION_VERSION=0x0002000A /D TIANO_RELEASE_VERSION=0x00080006
> -
>  [BuildOptions]
>    RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu=7-A.security
>    *_*_*_CC_FLAGS  = -DDISABLE_NEW_DEPRECATED_INTERFACES
> @@ -264,5 +253,5 @@
>    EmbeddedPkg/Drivers/AndroidFastbootTransportUsbDxe/FastbootTransportUsbDxe.inf
>    EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcpDxe.inf
>
> -[Components.IA32, Components.X64, Components.IPF, Components.ARM]
> +[Components.IA32, Components.X64, Components.ARM]
>    EmbeddedPkg/GdbStub/GdbStub.inf
> diff --git a/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf b/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf
> index 02f80579b1..256a85a9d1 100644
> --- a/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf
> +++ b/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf
> @@ -24,7 +24,7 @@
>  #
>  # The following information is for reference only and not required by the build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
>
>  [Sources.common]
> diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> index 19e5a298f3..2320dec8b7 100644
> --- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> +++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> @@ -23,7 +23,7 @@
>
>
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
>
>  [Sources.common]
> diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> index b27b0441d5..fa78a811e6 100644
> --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> @@ -27,7 +27,7 @@
>
>
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
>
>  [Sources.common]
> --
> 2.16.2.windows.1
>