From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 77FEA21296B1B for ; Tue, 12 Jun 2018 23:59:51 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id r24-v6so2310293ioh.9 for ; Tue, 12 Jun 2018 23:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=v4BH/+SujJsL0VcvySgnnl4LVumkD/OkTNjWJTOkBtw=; b=bv0e3DHvN4/PMp/TaV0pxr2Rzn3d7VW9G4BbSVIdv948fLZPkgrUq1f9QIIEVJENL6 6SnpXPjFupX5jA1R2xVs/+KiSpP8kaU11R+A8pqGnTgB3wgkhz+IuWe8+sYBjh8fyHNI o6Ym+cRnoP7FZqJr1DgMfAEUeBN+tehystahE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=v4BH/+SujJsL0VcvySgnnl4LVumkD/OkTNjWJTOkBtw=; b=B0XUtmQAF36htosGdLRJn9JTJyKICwek1tP6+Y+aCFXjGWjFIyyIDEiXF8odrLQqbC jknlfiVcnMe21tBDlR3EFvfxX98gw4p5bo3MG4USO+pGdFKy8UAsUWAe+jPXOchSolNs P5gujBEsGGKJKPiWGHa2g5RFyLPVsjN0epSm61N6J63I3WLeXgtmCxLMcZg12QdC+wPs HYNRdGZpvfocgRvRDm3kKnOM+VhhgN3WWknwntOmEV/GbtN413J+eHb1jBSjV+MZdXh5 A6sdoFweRyrdUo/bRpLe9td3PUmo0oJgjzwZLt9/ncBNXNsqHZQGyt3QJ5bB1tQHSXxF YnVA== X-Gm-Message-State: APt69E1MGxoMEzwFZuv09QvRQkjy80tFvyK+Xo7N8hcXIs+QgMz3+CWe BvYy0qNgs9VQgaaJFFmxTBT0sTNsXWBS/DZpGHstwQ== X-Google-Smtp-Source: ADUXVKLpWBbtn2rBRU+dB7nsUjROoQDdRWqB7Q/eDd1cAPfB0q8jufDLrNSAh/0f3CyzJP/Phw0+pWz2nHwrzI8+cGg= X-Received: by 2002:a6b:520d:: with SMTP id g13-v6mr3818563iob.60.1528873190834; Tue, 12 Jun 2018 23:59:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Tue, 12 Jun 2018 23:59:50 -0700 (PDT) In-Reply-To: <20180613034402.7708-1-chen.a.chen@intel.com> References: <20180613034402.7708-1-chen.a.chen@intel.com> From: Ard Biesheuvel Date: Wed, 13 Jun 2018 08:59:50 +0200 Message-ID: To: chenc2 Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Michael D Kinney Subject: Re: [PATCH 13/37] EmbeddedPkg: Removing ipf which is no longer supported from edk2. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 06:59:51 -0000 Content-Type: text/plain; charset="UTF-8" On 13 June 2018 at 05:44, chenc2 wrote: > Removing rules for Ipf sources file: > * Remove the source file which path with "ipf" and also listed in > [Sources.IPF] section of INF file. > * Remove the source file which listed in [Components.IPF] section > of DSC file and not listed in any other [Components] section. > * Remove the embedded Ipf code for MDE_CPU_IPF. > > Removing rules for Inf file: > * Remove IPF from VALID_ARCHITECTURES comments. > * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section. > * Remove the INF which only listed in [Components.IPF] section in DSC. > * Remove statements from [BuildOptions] that provide IPF specific flags. > * Remove any IPF sepcific sections. > > Removing rules for Dec file: > * Remove [Includes.IPF] section from Dec. > > Removing rules for Dsc file: > * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC. > * Remove any IPF specific sections. > * Remove statements from [BuildOptions] that provide IPF specific flags. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Michael D Kinney > Signed-off-by: chenc2 > Contributed-under: TianoCore Contribution Agreement 1.1 Reviewed-by: Ard Biesheuvel > --- > .../Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf | 2 +- > EmbeddedPkg/EmbeddedPkg.dsc | 15 ++------------- > EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf | 2 +- > EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +- > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 +- > 5 files changed, 6 insertions(+), 17 deletions(-) > > diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf > index d6bbf6932a..ba8da8c950 100644 > --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf > +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboardDxe.inf > @@ -25,7 +25,7 @@ > # > # The following information is for reference only and not required by the build tools. > # > -# VALID_ARCHITECTURES = IA32 X64 IPF ARM AARCH64 > +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 > # > # DRIVER_BINDING = gVirtualKeyboardDriverBinding > # COMPONENT_NAME = gVirtualKeyboardComponentName > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > index e6fad5e58b..bfbeea7f0b 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dsc > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > @@ -27,7 +27,7 @@ > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/Embedded > - SUPPORTED_ARCHITECTURES = IA32|X64|IPF|ARM|AARCH64 > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > @@ -199,17 +199,6 @@ > gEmbeddedTokenSpaceGuid.PcdTimerVector|7 > gEmbeddedTokenSpaceGuid.PcdTimerPeriod|100000 > > -[PcdsFixedAtBuild.IPF] > - gEfiMdePkgTokenSpaceGuid.PcdIoBlockBaseAddressForIpf|0x0ffffc000000 > - > -# > -# This makes it so you can source level debug with NT32. VC++ debugger limitiation! > -# > -#[BuildOptions] > -# DEBUG_*_IA32_DLINK_FLAGS = /EXPORT:InitializeDriver=$(IMAGE_ENTRY_POINT) /ALIGN:4096 /SUBSYSTEM:CONSOLE > -# RELEASE_*_IA32_DLINK_FLAGS = /ALIGN:4096 > -# *_*_IA32_CC_FLAGS = /D EFI_SPECIFICATION_VERSION=0x0002000A /D TIANO_RELEASE_VERSION=0x00080006 > - > [BuildOptions] > RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu=7-A.security > *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES > @@ -264,5 +253,5 @@ > EmbeddedPkg/Drivers/AndroidFastbootTransportUsbDxe/FastbootTransportUsbDxe.inf > EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcpDxe.inf > > -[Components.IA32, Components.X64, Components.IPF, Components.ARM] > +[Components.IA32, Components.X64, Components.ARM] > EmbeddedPkg/GdbStub/GdbStub.inf > diff --git a/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf b/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf > index 02f80579b1..256a85a9d1 100644 > --- a/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf > +++ b/EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf > @@ -24,7 +24,7 @@ > # > # The following information is for reference only and not required by the build tools. > # > -# VALID_ARCHITECTURES = IA32 X64 IPF EBC > +# VALID_ARCHITECTURES = IA32 X64 EBC > # > > [Sources.common] > diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > index 19e5a298f3..2320dec8b7 100644 > --- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > +++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > @@ -23,7 +23,7 @@ > > > # > -# VALID_ARCHITECTURES = IA32 X64 IPF EBC > +# VALID_ARCHITECTURES = IA32 X64 EBC > # > > [Sources.common] > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > index b27b0441d5..fa78a811e6 100644 > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > @@ -27,7 +27,7 @@ > > > # > -# VALID_ARCHITECTURES = IA32 X64 IPF EBC > +# VALID_ARCHITECTURES = IA32 X64 EBC > # > > [Sources.common] > -- > 2.16.2.windows.1 >