Re: [PATCH] ArmPlatformPkg/MemoryInitPeiLib: mark primary FV region as boot services data

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 28 February 2018 at 15:03, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Jan 02, 2018 at 03:50:34PM +0000, Ard Biesheuvel wrote:
>> Commit 8ae5fc182941 ("ArmPlatformPkg/MemoryInitPeiLib: don't reserve
>> primary FV in memory") deleted the code that removes the memory covering
>> the primary firmware volume from the memory map. The assumption was that
>> this is no longer necessary now that we no longer expose compression and
>> PE/COFF loader library code from the PrePi module to DXE core.
>>
>> However, the FV is still declared, and so code may attempt to access it
>> anyway, which may cause unexpected results depending on whether the
>> memory has been reused for other purposes in the mean time.
>>
>> So reinstate the code that splits off the resource descriptor HOB that
>> describes the firmware device, but this time, don't mark the memory as
>> unusable, but create a memory allocation HOB that marks the region as
>> boot services data.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> So, this looks like a necessary fix.
> However, there are many line-length violations below.
> And it's not apparent how fixing that would make the code more
> readable.
>
> So rather than asking for a rewrite - could you split the revert
> from the modification?
>

Sure.