From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2AE721F0DA77 for ; Mon, 12 Feb 2018 06:19:41 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id e1so6678881ita.0 for ; Mon, 12 Feb 2018 06:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6pgqhJAe2VLNek1Z3nWysCn6XGHIcAPr/CmoamgIQ4Y=; b=fzRFp6q02po4b+e5GNNKyl6nAJg8n/YI0+Dr6ZUvLitk4QoPOkL/DABnEONg/cJck5 jXZ4yu33sSWwzP9gimtcRJPSwbI8Q2FGgdS+wWHMC1f20EruD/Ig9MjTsppYnatrKd7h 0SBIPitpGUqSfax9vfHKkiwjy2tD8iJ4gupM8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6pgqhJAe2VLNek1Z3nWysCn6XGHIcAPr/CmoamgIQ4Y=; b=caSflSHQtOskbNq8XS1h5Xkr/FGb/6ALME2q5UAi6jaitxN+7s8ifXc85C70T7hC+8 va1nb4lj2Oqb0gTtRpqjwvBstE21ZgiQH8CsWML9rOomwtN8lhOYhehDV/TAx3iGhPqC xPZhqNA99AFmPs7low9UwImcnhSvqurQrm4a9Lut7Qj0B4pLC2ifjv3C1HDoBgRQdf8F ttD1FBexiHyBAWbXIrbhnFz25yK3FslgYDN5lajJkJoRPIOEEPpP14ofiykXuBj7agXa 5Uh/67SLDU8VcxlbSBwKu9lSnZy+3mEGvWnUtP018bUs91cP8Tx1d4wrq9F8Sh/R2+Js Zw0A== X-Gm-Message-State: APf1xPBw1aKCzFzm427KMuwZcYWFgftV4XMN3Zc8LB+7curhAyGOKZCn o2vpQpFhsvr7c49dpqq8oCTgfQvD61d/SskG1zj6sQ== X-Google-Smtp-Source: AH8x224DPBa0SYMynsTUUOTunibvhQq84zygCzsqPDQMqlrYaX5QEqU0t/JS0ApOlVykvnUAtz7LWrpoGsKRNnZZ2I4= X-Received: by 10.36.139.134 with SMTP id g128mr5197400ite.59.1518445530290; Mon, 12 Feb 2018 06:25:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Mon, 12 Feb 2018 06:25:29 -0800 (PST) In-Reply-To: <20180212134513.6882-2-lersek@redhat.com> References: <20180212134513.6882-1-lersek@redhat.com> <20180212134513.6882-2-lersek@redhat.com> From: Ard Biesheuvel Date: Mon, 12 Feb 2018 14:25:29 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Jordan Justen Subject: Re: [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 14:19:42 -0000 Content-Type: text/plain; charset="UTF-8" On 12 February 2018 at 13:45, Laszlo Ersek wrote: > These are listed under "ShellPkg/Application/Shell/Shell.inf", but they > have been commented out ever since commit 345a0c8fce38 ("OvmfPkg: Add > support for UEFI shell", 2011-06-26). No such lib classes exist in edk2. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 -- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 -- > OvmfPkg/OvmfPkgX64.dsc | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index e10f8986077d..fbe0f790e431 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -807,8 +807,6 @@ [Components] > !endif > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > -# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf > -# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index a31c7919ad0f..fb10e0b0f2e4 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -816,8 +816,6 @@ [Components.X64] > !endif > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > -# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf > -# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index bc433a972400..a31551f5ae24 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -814,8 +814,6 @@ [Components] > !endif > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > -# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf > -# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > > > -- > 2.14.1.3.gb7cf6e02401b > >